Chris Lattner wrote: > > On Apr 26, 2007, at 1:11 PM, Jeff Cohen wrote: > >> Absolutely true. This change will cause the test to fail on the BSDs, >> which will complain that malloc.h has been replaced by stdlib.h. Please >> use a different test. > > Better yet, just unconditionally #include <stdlib.h> and eliminate > <malloc.h> > > -Chris
It already does include stdlib.h. I assume it isn't enough on his system. > >> >> Andrew Lenharth wrote: >>> Changes in directory llvm-test/MultiSource/Benchmarks/Olden/voronoi: >>> >>> newvor.c updated: 1.11 -> 1.12 >>> --- >>> Log message: >>> >>> I think the correct thing to do is decide if malloc.h should be >>> included based on OS, not arch >>> >>> --- >>> Diffs of the changes: (+1 -1) >>> >>> newvor.c | 2 +- >>> 1 files changed, 1 insertion(+), 1 deletion(-) >>> >>> >>> Index: llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c >>> diff -u llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.11 >>> llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.12 >>> --- llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.11 >>> Mon Apr 17 12:55:40 2006 >>> +++ llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c Thu >>> Apr 26 14:55:25 2007 >>> @@ -4,7 +4,7 @@ >>> #include <stdlib.h> >>> #include "defines.h" >>> >>> -#if defined(__alpha__) >>> +#if defined(__alpha__) || defined(__x86_64__) >>> #include <malloc.h> >>> #endif >>> >>> >>> >>> >>> _______________________________________________ >>> llvm-commits mailing list >>> llvm-commits@cs.uiuc.edu >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits >>> >>> >>> >>> >> >> _______________________________________________ >> llvm-commits mailing list >> llvm-commits@cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits > > > > _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
