Unless Chris has any comments, please fix the createRegisterCoalescer () issue and then check it in (or send the patch).
I am fixing a coalescer bug at this point. Please merge in my changes if I happen to get that in before you do. Thanks, Evan On May 9, 2007, at 4:54 PM, David A. Greene wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Evan Cheng wrote: >> Hi, >> >> The patch seems pretty safe to me. The only thing I am not sure >> about is: > > [snip] > >> It's not clear to me if this is the right way to model this pass. >> After >> all, this is not an analysis pass. Perhaps the right thing to do >> is to >> model this after the register allocator. Add a >> createRegisterCoalescer() >> to Passes.cpp which would allow us to choose the one we want. Then >> register the pass in LLVMTargetMachine.cpp. Chris? What do you say? > > Yeah, I wasn't sure about that either. I modeled it after the way > that > out-of-ssa conversion is done since LinearScan assumes that coalescing > has been done. > > I think your suggestion of createRegisterCoalescer() is the right > solution in the long run. My goal here was to submit the first phase > of a larger refactoring effort that separated coalescing from > live interval analysis but tried not to do anything else dramatic. > > -Dave > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.6 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org > > iD8DBQFGQl9DgQsI8xjTYs8RAm5mAJ9mOWIQKNX63QHhh46SZDkx2HIW5QCaAtl5 > 3jHR+bEO1bQ2PGs6W52rhGA= > =ctF+ > -----END PGP SIGNATURE----- > _______________________________________________ > llvm-commits mailing list > llvm-commits@cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits