> --- llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1.500 Fri Jun 22
> 09:59:07 2007
> +++ llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp Mon Jun 25
> 11:23:39 2007
> @@ -173,15 +173,13 @@
> + /// ScalarizeVectorOp - Given an operand of vector type, convert
> it into the
> + /// equivalent operation that returns a scalar value.
> + SDOperand ScalarizeVectorOp(SDOperand O);
This comment should explicitly mention that the function is only
supposed to be called on single-element vector types.
> Index: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
> diff -u llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1.409 llvm/
> lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1.410
> --- llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1.409 Fri Jun 22
> 09:59:07 2007
> +++ llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp Mon Jun 25
> 11:23:39 2007
> @@ -673,7 +673,9 @@
> SDOperand SelectionDAG::getConstantFP(double Val, MVT::ValueType VT,
> bool isTarget) {
> assert(MVT::isFloatingPoint(VT) && "Cannot create integer FP
> constant!");
> - if (VT == MVT::f32)
> + MVT::ValueType EltVT =
> + MVT::isVector(VT) ? MVT::getVectorElementType(VT) : VT;
I don't understand this change. getConstantFP shouldn't be called on
vectors, should it? This seems to be a strange thing to overload.
-Chris
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
