Author: lattner Date: Fri Nov 23 02:46:22 2007 New Revision: 44286 URL: http://llvm.org/viewvc/llvm-project?rev=44286&view=rev Log: Fix a bug where we'd try to find a scev value for a bitcast operand, even though the bitcast operand did not have integer type. This fixes PR1814.
Added: llvm/trunk/test/Transforms/IndVarsSimplify/2007-11-23-BitcastCrash.ll Modified: llvm/trunk/lib/Analysis/ScalarEvolution.cpp Modified: llvm/trunk/lib/Analysis/ScalarEvolution.cpp URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ScalarEvolution.cpp?rev=44286&r1=44285&r2=44286&view=diff ============================================================================== --- llvm/trunk/lib/Analysis/ScalarEvolution.cpp (original) +++ llvm/trunk/lib/Analysis/ScalarEvolution.cpp Fri Nov 23 02:46:22 2007 @@ -1470,6 +1470,9 @@ /// Analyze the expression. /// SCEVHandle ScalarEvolutionsImpl::createSCEV(Value *V) { + if (!isa<IntegerType>(V->getType())) + return SE.getUnknown(V); + if (Instruction *I = dyn_cast<Instruction>(V)) { switch (I->getOpcode()) { case Instruction::Add: @@ -2076,6 +2079,11 @@ if (Constant *C = dyn_cast<Constant>(Op)) { Operands.push_back(C); } else { + // If any of the operands is non-constant and if they are + // non-integer, don't even try to analyze them with scev techniques. + if (!isa<IntegerType>(Op->getType())) + return V; + SCEVHandle OpV = getSCEVAtScope(getSCEV(Op), L); if (SCEVConstant *SC = dyn_cast<SCEVConstant>(OpV)) Operands.push_back(ConstantExpr::getIntegerCast(SC->getValue(), Added: llvm/trunk/test/Transforms/IndVarsSimplify/2007-11-23-BitcastCrash.ll URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/IndVarsSimplify/2007-11-23-BitcastCrash.ll?rev=44286&view=auto ============================================================================== --- llvm/trunk/test/Transforms/IndVarsSimplify/2007-11-23-BitcastCrash.ll (added) +++ llvm/trunk/test/Transforms/IndVarsSimplify/2007-11-23-BitcastCrash.ll Fri Nov 23 02:46:22 2007 @@ -0,0 +1,20 @@ +; RUN: llvm-as < %s | opt -indvars -disable-output +; PR1814 +target datalayout = "e-p:32:32-f64:32:64-i64:32:64-f80:32:32" + +define void @FuncAt1938470480(i32, i32, i32, i32, i32, i32, i32, i32, i64, i64, i64, i64, i64, i64, i64, i64, i1, i1, i1, i1, i1, i1) { +EntryBlock: + br label %asmBlockAt738ab7f3 + +asmBlockAt738ab9b0: ; preds = %asmBlockAt738ab7f3 + %.lcssa6 = phi i64 [ %23, %asmBlockAt738ab7f3 ] ; <i64> [#uses=0] + ret void + +asmBlockAt738ab7f3: ; preds = %asmBlockAt738ab7f3, %EntryBlock + %ebp95 = phi i32 [ 128, %EntryBlock ], [ %24, %asmBlockAt738ab7f3 ] ; <i32> [#uses=2] + sub <4 x i16> zeroinitializer, zeroinitializer ; <<4 x i16>>:22 [#uses=1] + bitcast <4 x i16> %22 to i64 ; <i64>:23 [#uses=1] + add i32 %ebp95, -64 ; <i32>:24 [#uses=1] + icmp ult i32 %ebp95, 64 ; <i1>:25 [#uses=1] + br i1 %25, label %asmBlockAt738ab9b0, label %asmBlockAt738ab7f3 +} _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits