Andrew, I xfailed your test. If you prefer to remove it, please do, otherwise please fix :)
-Chris On Nov 27, 2007, at 1:57 PM, Bill Wendling wrote: > Hi Andrew, > > I'm getting this failure now: > > FAIL: /Volumes/Gir/devel/llvm/llvm.src/test/CodeGen/Alpha/mul5.ll > Failed with exit(1) at line 1 > while running: llvm-upgrade < > /Volumes/Gir/devel/llvm/llvm.src/test/CodeGen/Alpha/mul5.ll | llvm-as > | llc -march=alpha | not grep -i mul > mulq $16,$0,$0 > mulq $16,252,$0 > mulq $16,$0,$0 > child process exited abnormally > > Do you think that it's related to your patch? > > -bw > > On Nov 27, 2007 10:31 AM, Andrew Lenharth <[EMAIL PROTECTED]> > wrote: >> Author: alenhar2 >> Date: Tue Nov 27 12:31:30 2007 >> New Revision: 44370 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=44370&view=rev >> Log: >> something wrong with this opt >> >> Added: >> llvm/trunk/test/CodeGen/Alpha/2007-11-27-mulneg3.ll >> Modified: >> llvm/trunk/lib/Target/Alpha/AlphaInstrInfo.td >> >> Modified: llvm/trunk/lib/Target/Alpha/AlphaInstrInfo.td >> URL: >> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Alpha/AlphaInstrInfo.td?rev=44370&r1=44369&r2=44370&view=diff >> >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- llvm/trunk/lib/Target/Alpha/AlphaInstrInfo.td (original) >> +++ llvm/trunk/lib/Target/Alpha/AlphaInstrInfo.td Tue Nov 27 >> 12:31:30 2007 >> @@ -1086,16 +1086,18 @@ >> (ADDQr (SLr GPRC:$RA, (nearP2X immRemP2:$imm)), (SLi GPRC: >> $RA, (nearP2RemX immRemP2:$imm)))>; >> >> //n is below a power of 2 >> -def : Pat<(mul GPRC:$RA, immRem1n:$imm), >> - (SUBQr (SLr GPRC:$RA, (nearP2X immRem1n:$imm)), GPRC: >> $RA)>; >> -def : Pat<(mul GPRC:$RA, immRem2n:$imm), >> - (SUBQr (SLr GPRC:$RA, (nearP2X immRem2n:$imm)), (ADDQr >> GPRC:$RA, GPRC:$RA))>; >> -def : Pat<(mul GPRC:$RA, immRem3n:$imm), >> - (SUBQr (SLr GPRC:$RA, (nearP2X immRem3n:$imm)), (S4SUBQr >> GPRC:$RA, GPRC:$RA))>; >> -def : Pat<(mul GPRC:$RA, immRem4n:$imm), >> - (SUBQr (SLr GPRC:$RA, (nearP2X immRem4n:$imm)), (SLi >> GPRC:$RA, 2))>; >> -def : Pat<(mul GPRC:$RA, immRem5n:$imm), >> - (SUBQr (SLr GPRC:$RA, (nearP2X immRem5n:$imm)), (S4ADDQr >> GPRC:$RA, GPRC:$RA))>; >> -def : Pat<(mul GPRC:$RA, immRemP2n:$imm), >> - (SUBQr (SLr GPRC:$RA, (nearP2X immRemP2n:$imm)), (SLi >> GPRC:$RA, (nearP2RemX immRemP2n:$imm)))>; >> +//FIXME: figure out why something is truncating the imm to 32bits >> +// this will fix 2007-11-27-mulneg3 >> +//def : Pat<(mul GPRC:$RA, immRem1n:$imm), >> +// (SUBQr (SLr GPRC:$RA, (nearP2X immRem1n:$imm)), GPRC: >> $RA)>; >> +//def : Pat<(mul GPRC:$RA, immRem2n:$imm), >> +// (SUBQr (SLr GPRC:$RA, (nearP2X immRem2n:$imm)), (ADDQr >> GPRC:$RA, GPRC:$RA))>; >> +//def : Pat<(mul GPRC:$RA, immRem3n:$imm), >> +// (SUBQr (SLr GPRC:$RA, (nearP2X immRem3n:$imm)), >> (S4SUBQr GPRC:$RA, GPRC:$RA))>; >> +//def : Pat<(mul GPRC:$RA, immRem4n:$imm), >> +// (SUBQr (SLr GPRC:$RA, (nearP2X immRem4n:$imm)), (SLi >> GPRC:$RA, 2))>; >> +//def : Pat<(mul GPRC:$RA, immRem5n:$imm), >> +// (SUBQr (SLr GPRC:$RA, (nearP2X immRem5n:$imm)), >> (S4ADDQr GPRC:$RA, GPRC:$RA))>; >> +//def : Pat<(mul GPRC:$RA, immRemP2n:$imm), >> +// (SUBQr (SLr GPRC:$RA, (nearP2X immRemP2n:$imm)), (SLi >> GPRC:$RA, (nearP2RemX immRemP2n:$imm)))>; >> } //Added complexity >> >> Added: llvm/trunk/test/CodeGen/Alpha/2007-11-27-mulneg3.ll >> URL: >> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Alpha/2007-11-27-mulneg3.ll?rev=44370&view=auto >> >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- llvm/trunk/test/CodeGen/Alpha/2007-11-27-mulneg3.ll (added) >> +++ llvm/trunk/test/CodeGen/Alpha/2007-11-27-mulneg3.ll Tue Nov 27 >> 12:31:30 2007 >> @@ -0,0 +1,13 @@ >> +; RUN: llvm-as < %s | llc -march=alpha >> + >> +;FIXME: this should produce no mul inst. But not crashing will >> have to do for now >> + >> +; ModuleID = 'Output/bugpoint-train/bugpoint-reduced-simplified.bc' >> +target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16- >> i32:32:32-i64:32:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128- >> a0:0:64-f128:128:128" >> +target triple = "alphaev6-unknown-linux-gnu" >> + >> +define fastcc i32 @getcount(i32 %s) { >> +cond_next43: ; preds = %bb27 >> + %tmp431 = mul i32 %s, -3 >> + ret i32 %tmp431 >> +} >> >> >> _______________________________________________ >> llvm-commits mailing list >> llvm-commits@cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits >> > _______________________________________________ > llvm-commits mailing list > llvm-commits@cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits