http://llvm.org/bugs/show_bug.cgi?id=3927
Chris Lattner <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #1 from Chris Lattner <[email protected]> 2009-04-18 01:46:57 --- Nice catch, I'm impressed that you found that by inspection. Fixed here: http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20090413/015777.html I checked the rest of liblex for uses of is(tok::identifier). The ones that are left are: lib/Lex/Preprocessor.cpp: assert(Identifier.is(tok::identifier) && "Not an identifier!"); This is checking for identifier info lookup, it is ok. lib/Lex/TokenLexer.cpp: if (Tok.is(tok::identifier) && RHS.is(tok::identifier)) { This is an optimization, it doesn't matter for keywords. lib/Lex/TokenLexer.cpp: if (Tok.is(tok::identifier)) { This is another identifierinfo lookup case. So I think we're ok, nice catch! -- Configure bugmail: http://llvm.org/bugs/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ LLVMbugs mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/llvmbugs
