Hi Johannes,
2014-02-20 16:09 GMT+01:00 Johannes Lorenz <[email protected]>:
> 1. The patch works correcty, except for stereo channels.
Cool! :-) First of all: please don't be disappointed - it probably
won't be included for 1.0.0 anymore as it touches the inner core and
chances are high that it could break something. We will merge it after
the release so it can be part of 1.0.1 or 1.0.2.
> If you connect the
> left control knob and have stereo link enabled, the left works logarithmic (as
> wanted), but the right is still linear.
Does the right one have a hint about log scale? Probably I need to see
the code/patch and fix it later.
> 2. I found this code here in AutomatableModel.cpp
>
> // correct rounding error at the border
> if( qAbs<float>( value - m_maxValue ) < typeInfo<float>::minEps() *
> qAbs<float>( m_step ) )
> {
> value = m_maxValue;
> }
>
> // correct rounding error if value = 0
> if( qAbs<float>( value ) < typeInfo<float>::minEps() * qAbs<float>(
> m_step
> ) )
> {
> value = 0;
> }
>
> Why is it not "(value - m_minValue)" before the "<" in the second if? I think
> this would lead to misbehaviour if m_minValue != 0.
I looks like this case explicitely catches rounding errors around 0
and not around m_minValue. You're right that it probably should catch
m_minValue as well. So instead of replacing the logic, I'd add another
rounding case for m_minValue (even though it might be redundant in
case m_minValue is 0). Do you want to add the code?
Toby
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
LMMS-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/lmms-devel
