On 03/19/2014 08:50 PM, Johannes Lorenz wrote:
>> We also need to ensure that these changes don't break any existing UI
>> elements. So if we make changes to how widgets are initialized, then all
>> the parts of the UI using that widget need to be adapted to those changes.
> Yes, though the number of changes will be very small (existing code will just 
> be moved into other functions). So it should hopefully not happen.

Hopefully, yeah.
>> While we're at it, we should move as much of the graphical attributes
>> (widget colours, backgrounds, images etc.) to the CSS, which should be
>> doable since we can set values for qproperties in the CSS.
> IIRC, this would mean that for every widget, we'd use the default ctor, and 
> instead pass the other parameters via css script? Due to the amount of 
> overall 
> widgets, this could be a lot of work. It sounds sane to me, though.

Yeah. It may be lots of work. Of course, some things can still be set in
code - like if changing the size of a widget would break a layout or
break other functionality, we can keep hardcoding the size in code so
themers won't accidentally mess with it and then wonder why things don't
work.

I was planning to start migrating graphical properties to CSS after
1.0.0 in any case...

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
LMMS-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/lmms-devel

Reply via email to