Do we still worry about Petri's comment? Right now
platform/linux-generic/include/api/odp_byteorder.h includes endian.h.
Anyway that should be the subject of a different patch so I think this
can go in.
On Mon, Nov 3, 2014 at 10:53 PM, Mike Holmes <mike.hol...@linaro.org> wrote:
> API headers should not include C std lib headers directly
>
> Signed-off-by: Mike Holmes <mike.hol...@linaro.org>
Reviewed-and-tested-by: Ciprian Barbu <ciprian.ba...@linaro.org>
> ---
>
> v2:
> remove endian.h it should be cleaned up during configuration / build
>
> platform/linux-generic/include/api/odp_debug.h | 3 +--
> platform/linux-generic/include/api/odp_std_types.h | 2 ++
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/platform/linux-generic/include/api/odp_debug.h
> b/platform/linux-generic/include/api/odp_debug.h
> index c9b2edd..99f4574 100644
> --- a/platform/linux-generic/include/api/odp_debug.h
> +++ b/platform/linux-generic/include/api/odp_debug.h
> @@ -12,8 +12,7 @@
> #ifndef ODP_DEBUG_H_
> #define ODP_DEBUG_H_
>
> -#include <stdio.h>
> -#include <stdlib.h>
> +#include <odp_std_types.h>
>
> #ifdef __cplusplus
> extern "C" {
> diff --git a/platform/linux-generic/include/api/odp_std_types.h
> b/platform/linux-generic/include/api/odp_std_types.h
> index b12a2f3..e3aa5ab 100644
> --- a/platform/linux-generic/include/api/odp_std_types.h
> +++ b/platform/linux-generic/include/api/odp_std_types.h
> @@ -26,6 +26,8 @@ extern "C" {
> #include <stdint.h>
> #include <inttypes.h>
> #include <limits.h>
> +#include <stdio.h>
> +#include <stdlib.h>
>
>
>
> --
> 2.1.0
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
