On Wed, Dec 10, 2014 at 11:59 AM, Ciprian Barbu <ciprian.ba...@linaro.org> wrote: > On Tue, Dec 9, 2014 at 4:16 PM, Ciprian Barbu <ciprian.ba...@linaro.org> > wrote: >> On Tue, Dec 9, 2014 at 3:46 PM, Savolainen, Petri (NSN - FI/Espoo) >> <petri.savolai...@nsn.com> wrote: >>> After the minor documentation change (see under), for the entire patch set: >> >> Yeah, sorry about that. Thanks! > > Anders spotted I'm missing checks, v2 on the way. > >> >>> >>> Reviewed-by: Petri Savolainen <petri.savolai...@linaro.org> >>> >>> >>>> -----Original Message----- >>>> From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp- >>>> boun...@lists.linaro.org] On Behalf Of ext Ciprian Barbu >>>> Sent: Monday, December 08, 2014 3:59 PM >>>> To: lng-odp@lists.linaro.org >>>> Subject: [lng-odp] [PATCH 1/2] api: queue: add odp_queue_sched_prio and >>>> odp_queue_sched_group >>>> >>>> Signed-off-by: Ciprian Barbu <ciprian.ba...@linaro.org> >>>> --- >>>> platform/linux-generic/include/api/odp_queue.h | 18 ++++++++++++++++++ >>>> 1 file changed, 18 insertions(+) >>>> >>>> diff --git a/platform/linux-generic/include/api/odp_queue.h >>>> b/platform/linux-generic/include/api/odp_queue.h >>>> index b8ac4bb..d25fd65 100644 >>>> --- a/platform/linux-generic/include/api/odp_queue.h >>>> +++ b/platform/linux-generic/include/api/odp_queue.h >>>> @@ -222,6 +222,24 @@ odp_queue_type_t odp_queue_type(odp_queue_t queue); >>>> odp_schedule_sync_t odp_queue_sched_type(odp_queue_t queue); >>>> >>>> /** >>>> + * Queue priority >>> >>> Queue schedule priority >>> >>>> + * >>>> + * @param queue Queue handle >>>> + * >>>> + * @return Queue priority >>> >>> @return Queue schedule priority
Question: Can these two APIs fail (e.g. invalid queue handle) ? What should the return value be if the queue handle is invalid? Maybe introduce a ODP_SCHEDULE_PRIO_INVALID? >>> >>>> + */ >>>> +odp_schedule_prio_t odp_queue_sched_prio(odp_queue_t queue); >>>> + >>>> +/** >>>> + * Queue group >>> >>> Queue schedule group >>> >>>> + * >>>> + * @param queue Queue handle >>>> + * >>>> + * @return Queue group >>> >>> @return Queue schedule group >>> >>>> + */ >>>> +odp_schedule_group_t odp_queue_sched_group(odp_queue_t queue); >>>> + >>>> +/** >>>> * @} >>>> */ >>>> >>>> -- >>>> 1.8.3.2 >>>> >>>> >>>> _______________________________________________ >>>> lng-odp mailing list >>>> lng-odp@lists.linaro.org >>>> http://lists.linaro.org/mailman/listinfo/lng-odp _______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp
