I believe you are correct. But another notch on your debugging gun. :) On Wed, Dec 10, 2014 at 12:42 PM, Stuart Haslam <stuart.has...@arm.com> wrote:
> On Tue, Dec 09, 2014 at 10:28:09PM +0000, Bill Fischofer wrote: > > Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> > > --- > > v2 reflects review comments by Stuart > > > > - Correct miscelaneous errors in packet parser > > > > example/generator/odp_generator.c | 82 +- > > example/ipsec/odp_ipsec.c | 37 +- > > example/ipsec/odp_ipsec_stream.c | 25 +- > > example/l2fwd/odp_l2fwd.c | 3 +- > > example/packet/odp_pktio.c | 9 +- > > helper/include/odph_ip.h | 35 +- > > helper/include/odph_packet.h | 97 --- > > helper/include/odph_udp.h | 5 +- > > platform/linux-generic/Makefile.am | 1 - > > platform/linux-generic/include/api/odp_packet.h | 727 > ++++++++++++---- > > .../linux-generic/include/api/odp_platform_types.h | 21 +- > > .../linux-generic/include/odp_buffer_inlines.h | 54 ++ > > .../linux-generic/include/odp_buffer_internal.h | 1 + > > .../linux-generic/include/odp_packet_internal.h | 81 +- > > platform/linux-generic/odp_crypto.c | 11 +- > > platform/linux-generic/odp_packet.c | 912 > ++++++++++++++++----- > > platform/linux-generic/odp_packet_socket.c | 93 +-- > > 17 files changed, 1558 insertions(+), 636 deletions(-) > > delete mode 100644 helper/include/odph_packet.h > > > > [...] > > > +static inline void *packet_offset_map(odp_packet_hdr_t *pkt_hdr, > > + uint32_t offset, uint32_t *seglen) > > +{ > > + if (offset > pkt_hdr->frame_len) > > + return NULL; > > + > > + return buffer_map(&pkt_hdr->buf_hdr, > > + pkt_hdr->headroom + offset, > > + seglen, pkt_hdr->frame_len); > > Shouldn't the last argument be pkt_hdr->headroom + pkt_hdr->frame_len? > > -- > Stuart. > >
_______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp