In my system “make check” seg faults (in odp_init, etc) already with the current code from the repo.
-Petri From: ext Mike Holmes [mailto:mike.hol...@linaro.org] Sent: Tuesday, January 20, 2015 3:13 PM To: Petri Savolainen Cc: lng-odp Subject: Re: [lng-odp] [PATCH v2 00/16] Event introduction On 20 January 2015 at 06:17, Petri Savolainen <petri.savolai...@linaro.org<mailto:petri.savolai...@linaro.org>> wrote: This patch set introduces odp_event_t. It replaces odp_buffer_t in many places with odp_event_t. Events are the objects that are transimitted by and scheduled from queues. Event is the new "super class" for various events (buffers, packets, timeouts, etc). Various event types can be converted to odp_event_t (and back), but not to another event type. Buffer pool is also changed to a generic "pool". Pool and event types have been separated. There are matching pool types for buffer, packet and timeout events (as "buffer types" before). Later on, there can be event types without a matching pool type, and pool types without a matching event type. Some lines are over 80 chars. Those are mainly caused by temporary event <-> buffer, packet -> event -> buffer conversions and should be cleaned up from the implementation. This patch set does minimal implementation changes. It is not unreadable to have these changes checkpatch clean, one line that moved to two is very understandable. Also running these patches with "make check" after applying each one results in failures along the way. Starting fresh and applying all the patches at once and running make check gives PASS: odp_init PASS: odp_queue ../../test-driver: line 107: 18152 Segmentation fault (core dumped) "$@" > $log_file 2>&1 FAIL: odp_crypto PASS: odp_shm PASS: odp_schedule PASS: odp_pktio_run ../../test-driver: line 107: 21042 Segmentation fault (core dumped) "$@" > $log_file 2>&1 FAIL: odp_buffer PASS: odp_system FAIL: odp_timer PASS: odp_time PASS: odp_synchronizers make[5]: Entering directory '/home/mike/git/odp/test/validation' make[5]: Nothing to be done for 'all'. make[5]: Leaving directory '/home/mike/git/odp/test/validation' ============================================================================ Testsuite summary for OpenDataPlane 0.8.0 ============================================================================ # TOTAL: 11 # PASS: 8 # SKIP: 0 # XFAIL: 0 # FAIL: 3 # XPASS: 0 # ERROR: 0 ============================================================================ See test/validation/test-suite.log Please report to lng-odp@lists.linaro.org<mailto:lng-odp@lists.linaro.org> NB timer is sustable to failure until we get Olas latest code in. Petri Savolainen (16): api: event: Add odp_event_t api: event: odp_schedule and odp_queue_enq api: event: schedule_multi and queue_enq_multi api: event: odp_queue_deq api: event: odp_queue_deq_multi api: buffer: Removed odp_buffer_type api: packet: Removed odp_packet_to_buffer api: packet: Removed odp_packet_from_buffer api: timer: Use odp_event_t instead of odp_buffer_t api: crypto: Use odp_event_t instead of odp_buffer_t linux-generic: crypto: Use packet alloc for packet api: buffer_pool: Rename odp_buffer_pool.h to odp_pool.h api: pool: Rename pool params and remove buffer types api: pool: Rename odp_buffer_pool_ to odp_pool_ api: config: Renamed ODP_CONFIG_BUFFER_POOLS api: timer: Added timeout alloc and free example/generator/odp_generator.c | 38 ++-- example/ipsec/odp_ipsec.c | 70 +++---- example/ipsec/odp_ipsec_cache.c | 4 +- example/ipsec/odp_ipsec_cache.h | 2 +- example/ipsec/odp_ipsec_loop_db.c | 2 +- example/ipsec/odp_ipsec_loop_db.h | 12 +- example/ipsec/odp_ipsec_stream.c | 20 +- example/ipsec/odp_ipsec_stream.h | 2 +- example/l2fwd/odp_l2fwd.c | 28 +-- example/packet/odp_pktio.c | 28 +-- example/timer/odp_timer_test.c | 74 ++++---- platform/linux-generic/Makefile.am | 4 +- platform/linux-generic/include/api/odp.h | 3 +- platform/linux-generic/include/api/odp_buffer.h | 40 ++-- .../linux-generic/include/api/odp_buffer_pool.h | 177 ------------------ .../linux-generic/include/api/odp_classification.h | 2 +- platform/linux-generic/include/api/odp_config.h | 4 +- platform/linux-generic/include/api/odp_crypto.h | 16 +- platform/linux-generic/include/api/odp_event.h | 59 ++++++ platform/linux-generic/include/api/odp_packet.h | 29 +-- platform/linux-generic/include/api/odp_packet_io.h | 4 +- .../linux-generic/include/api/odp_platform_types.h | 10 +- platform/linux-generic/include/api/odp_pool.h | 202 +++++++++++++++++++++ platform/linux-generic/include/api/odp_queue.h | 32 ++-- platform/linux-generic/include/api/odp_schedule.h | 32 ++-- platform/linux-generic/include/api/odp_timer.h | 91 +++++++--- .../linux-generic/include/odp_buffer_inlines.h | 6 +- .../linux-generic/include/odp_buffer_internal.h | 20 +- .../include/odp_buffer_pool_internal.h | 22 +-- .../linux-generic/include/odp_crypto_internal.h | 2 +- .../linux-generic/include/odp_packet_internal.h | 8 +- platform/linux-generic/include/odp_packet_socket.h | 10 +- platform/linux-generic/odp_buffer.c | 12 +- platform/linux-generic/odp_buffer_pool.c | 141 +++++++------- platform/linux-generic/odp_crypto.c | 29 +-- platform/linux-generic/odp_event.c | 19 ++ platform/linux-generic/odp_packet.c | 34 ++-- platform/linux-generic/odp_packet_io.c | 14 +- platform/linux-generic/odp_packet_socket.c | 10 +- platform/linux-generic/odp_queue.c | 18 +- platform/linux-generic/odp_schedule.c | 48 ++--- platform/linux-generic/odp_timer.c | 54 ++++-- test/performance/odp_scheduling.c | 105 ++++++----- test/validation/buffer/odp_buffer_pool_test.c | 192 +++++++++++--------- test/validation/buffer/odp_buffer_test.c | 26 +-- test/validation/buffer/odp_buffer_tests.h | 2 +- test/validation/buffer/odp_packet_test.c | 50 ++--- test/validation/crypto/odp_crypto_test_async_inp.c | 43 +++-- test/validation/crypto/odp_crypto_test_sync_inp.c | 11 +- test/validation/odp_crypto.c | 28 +-- test/validation/odp_pktio.c | 79 ++++---- test/validation/odp_queue.c | 50 ++--- test/validation/odp_schedule.c | 44 +++-- test/validation/odp_timer.c | 90 +++++---- 54 files changed, 1208 insertions(+), 944 deletions(-) delete mode 100644 platform/linux-generic/include/api/odp_buffer_pool.h create mode 100644 platform/linux-generic/include/api/odp_event.h create mode 100644 platform/linux-generic/include/api/odp_pool.h create mode 100644 platform/linux-generic/odp_event.c -- 2.2.2 _______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org<mailto:lng-odp@lists.linaro.org> http://lists.linaro.org/mailman/listinfo/lng-odp -- Mike Holmes Linaro Sr Technical Manager LNG - ODP
_______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp
