Wouldn't a cleaner fix be to change the routine signature from void * to void? It doesn't return so why should if have a return type in its signature in the first place?
On Wed, Jan 28, 2015 at 11:08 AM, Ola Liljedahl <ola.liljed...@linaro.org> wrote: > On 28 January 2015 at 17:23, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > > If you want to add returns you need to do it in all other examples also. > Someone should do it. We are not stopping Ciprian's patch because it > did not fix the whole universe? > > > Like example/packet > > > > Maxim. > > > > On 01/28/2015 07:01 PM, Ciprian Barbu wrote: > >> > >> Fix for https://bugs.linaro.org/show_bug.cgi?id=1161 > >> > >> Signe-off-by: Ciprian Barbu <ciprian.ba...@linaro.org> > >> --- > >> example/l2fwd/odp_l2fwd.c | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/example/l2fwd/odp_l2fwd.c b/example/l2fwd/odp_l2fwd.c > >> index 150de18..7c4e8bd 100644 > >> --- a/example/l2fwd/odp_l2fwd.c > >> +++ b/example/l2fwd/odp_l2fwd.c > >> @@ -146,6 +146,7 @@ static void *pktio_queue_thread(void *arg) > >> } > >> /* unreachable */ > >> + return NULL; > >> } > >> /** > >> @@ -233,6 +234,7 @@ static void *pktio_ifburst_thread(void *arg) > >> } > >> /* unreachable */ > >> + return NULL; > >> } > >> /** > > > > > > > > _______________________________________________ > > lng-odp mailing list > > lng-odp@lists.linaro.org > > http://lists.linaro.org/mailman/listinfo/lng-odp > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
_______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp
