The addition of tests_global_term() inadvertently masked test failures
by overwritting the value of ret.

Signed-off-by: Stuart Haslam <stuart.has...@linaro.org>
---
Coverity flagged this with CID 87973

 test/validation/common/odp_cunit_common.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/test/validation/common/odp_cunit_common.c 
b/test/validation/common/odp_cunit_common.c
index 655d157..83e5026 100644
--- a/test/validation/common/odp_cunit_common.c
+++ b/test/validation/common/odp_cunit_common.c
@@ -80,9 +80,8 @@ int main(void)
 
        CU_cleanup_registry();
 
-       ret = tests_global_term();
-       if (ret)
-               return ret;
+       if (0 != tests_global_term())
+               return -1;
 
        odp_term_local();
        odp_term_global();
-- 
2.1.1


_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to