On Tue, Mar 17, 2015 at 11:44:10AM +0200, Ciprian Barbu wrote:
> On Mon, Mar 16, 2015 at 1:48 PM, Stuart Haslam <stuart.has...@linaro.org> 
> wrote:
> > odp_scheduling_run always exits with code 0 so "make check" will never
> > report failures.
> >
> > Signed-off-by: Stuart Haslam <stuart.has...@linaro.org>
> > ---
> >  test/performance/odp_scheduling_run | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/test/performance/odp_scheduling_run 
> > b/test/performance/odp_scheduling_run
> > index 28b0ce5..738963e 100755
> > --- a/test/performance/odp_scheduling_run
> > +++ b/test/performance/odp_scheduling_run
> > @@ -3,13 +3,17 @@
> >  # Script that passes command line arguments to odp_scheduling test when
> >  # launched by 'make check'
> >
> > +ret=0
> > +
> >  run()
> >  {
> >         echo odp_scheduling_run starts with $1 worker threads
> >         echo ===============================================
> >
> > -       ./odp_scheduling -c $1
> > +       ./odp_schedling -c $1 || ret=1
> 
> Mistyped scheduling?
> 

Eek, yes, well spotted. It was actually a deliberate negative test that
I ran locally but obviously was not meant to be checked in. The next
patch in this series fixes it, but I'll resend the series with it tidied
up.

-- 
Stuart.

_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to