It seems like there is still a discussion floating on patch 2, about including helper code in the linux-generic implementation. I will have a look at the other patches, but I think you need to solve the issue with the ring code before marking the patchset as ready to be merged.
On Mon, May 18, 2015 at 3:55 PM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > If no more comments here can all reviewers add their review-by to that > patchset? So that I can merge that patches. > > Thank you, > Maxim. > > On 05/08/2015 12:57, Maxim Uvarov wrote: >> >> v5: - accounted all comments for previous v4 review. >> - do not modify any api function, everything is done inside >> linux-generic. >> >> Please review that version. >> >> Thank you, >> Maxim. >> >> >> Maxim Uvarov (4): >> linux-generic: zero params for pool create >> api ipc: update ring with shm proc argument >> linux-generic: add ipc pktio support >> ipc: example app >> >> configure.ac | 1 + >> example/Makefile.am | 2 +- >> example/ipc/.gitignore | 1 + >> example/ipc/Makefile.am | 7 + >> example/ipc/odp_ipc.c | 427 +++++++++++++++ >> helper/include/odp/helper/ring.h | 7 +- >> helper/ring.c | 12 +- >> platform/linux-generic/Makefile.am | 3 + >> .../linux-generic/include/odp_buffer_internal.h | 3 + >> .../linux-generic/include/odp_packet_io_internal.h | 16 + >> .../include/odp_packet_io_ipc_internal.h | 48 ++ >> platform/linux-generic/include/odp_shm_internal.h | 22 + >> platform/linux-generic/odp_packet_io.c | 19 +- >> platform/linux-generic/odp_packet_io_ipc.c | 603 >> +++++++++++++++++++++ >> platform/linux-generic/odp_pool.c | 23 +- >> platform/linux-generic/odp_schedule.c | 1 + >> platform/linux-generic/odp_shared_memory.c | 10 +- >> test/validation/odp_queue.c | 1 + >> 18 files changed, 1193 insertions(+), 13 deletions(-) >> create mode 100644 example/ipc/.gitignore >> create mode 100644 example/ipc/Makefile.am >> create mode 100644 example/ipc/odp_ipc.c >> create mode 100644 >> platform/linux-generic/include/odp_packet_io_ipc_internal.h >> create mode 100644 platform/linux-generic/include/odp_shm_internal.h >> create mode 100644 platform/linux-generic/odp_packet_io_ipc.c >> > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp _______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
