Hello Christophe,
I just added few tests cases which we tested with Ciprian for current
version. I think you don't need to remove
from PATH original directories. Comments are:
1.
I don't like that name. _main is not needed:
./test/validation/pktio/pktio_main
2.
Then I run ./scripts/builddeb and looks like that pktio_main is not
packaged.
But pktio_run script refers to it:
./pktio_run: 73: ./pktio_run:
/tmp/pktio1/bin/../../../test/validation/pktio/pktio_main: not found
3. Unable to start manually pktio_run script in build out of tree case:
../../opt/Linaro/odp2.git/platform/linux-generic/test/pktio/pktio_run
../../opt/Linaro/odp2.git/platform/linux-generic/test/pktio/pktio_run:
73:
../../opt/Linaro/odp2.git/platform/linux-generic/test/pktio/pktio_run:
/tmp/pktio2/../../../test/validation/pktio/pktio_main: not found
Best regards,
Maxim.
On 05/28/15 13:58, Christophe Milard wrote:
This series of patches comes following the request from Stuart to
see the effect of the new test structure on module pktio rather than on a
simpler module, such as 'random'.
Please, review carefully, keeping in mind that many of you have a better and
larger view on the whole environment... I can miss things :-) ...
Be also aware that after applying these patches, you end up with a mixed
environment: pktio will be ran from the platform side, while all other tests
will still be ran from the validation side: as a consequence, you will notice
that:
- the make check "grand total" (19 PASS) is now split 18 + 1: this split will
remain untill all tests are "moved" to the platform side.
- despite the creation of pktio own Makefile.am, a lot of complexity remains
in the validation Makefile.am: the complexity of the validation/Makefile.am
will reduce as tests gets moved, resulting in a simple list of modules.
- the tests results will spread between the validation and the platform sides.
I expect this to remain (depending on whether the test was platform
dependent,
or not).
This approach also requires to build the things in the following order:
1) ODP (i.e: platform/<platform>/ things)
2) the platform agnostic tests (i.e: validation/test/ things), using ODP.
3) the platform dependent tests (platform/<platform>/test)
This changed is introduced by patch "0005-validation-changing-build-order.patch"
which is a hack to workaround what seems to be an autotools limitation:
"SUBDIRS = @MACRO@" works, while
"SUBDIRS = xxx/@MACRO@/yyy" does not work.
This is hopefully a temporary fix as I assume that this directory structure
will change: Having the ODP code in "platform/<platform>/*" and the tests in
"platform/<platform>/tests" seems to imply that tests are a subpart of ODP,
which is not true.
When this patch is accepted, other modeles conversion will follows.
thanks for your time.
Christophe Milard (6):
validation: preparing for main in tests
validation: own main and renaming in odp_pktio.c
validation: cosmetic fixes in odp_pktio.c
validation: creating own dir and lib for pktio
validation: changing build order
validation: moving pktio plt specific to platform
Makefile.am | 8 +-
configure.ac | 6 +-
platform/Makefile.am | 1 -
platform/linux-generic/Makefile.am | 2 -
platform/linux-generic/test/.gitignore | 2 +
platform/linux-generic/test/Makefile.am | 8 +-
platform/linux-generic/test/pktio/.gitignore | 2 +
platform/linux-generic/test/pktio/Makefile.am | 2 +
platform/linux-generic/test/{ => pktio}/pktio_env | 0
.../linux-generic/test/pktio/pktio_run | 26 +++----
test/Makefile.inc | 7 +-
test/performance/odp_l2fwd_run | 4 +-
test/validation/.gitignore | 1 -
test/validation/Makefile.am | 49 ++++++------
test/validation/Makefile.inc | 7 ++
test/validation/common/.gitignore | 2 +
test/validation/common/Makefile.am | 10 +++
test/validation/common/odp_cunit_common.c | 18 +++--
test/validation/common/odp_cunit_common.h | 3 +
test/validation/pktio/.gitignore | 4 +
test/validation/pktio/Makefile.am | 8 ++
test/validation/{odp_pktio.c => pktio/pktio.c} | 89 +++++++++++-----------
test/validation/pktio/pktio.h | 7 ++
test/validation/pktio/pktio_main.c | 12 +++
24 files changed, 173 insertions(+), 105 deletions(-)
delete mode 100644 platform/Makefile.am
create mode 100644 platform/linux-generic/test/.gitignore
create mode 100644 platform/linux-generic/test/pktio/.gitignore
create mode 100644 platform/linux-generic/test/pktio/Makefile.am
rename platform/linux-generic/test/{ => pktio}/pktio_env (100%)
rename test/validation/odp_pktio_run =>
platform/linux-generic/test/pktio/pktio_run (70%)
create mode 100644 test/validation/Makefile.inc
create mode 100644 test/validation/common/.gitignore
create mode 100644 test/validation/common/Makefile.am
create mode 100644 test/validation/pktio/.gitignore
create mode 100644 test/validation/pktio/Makefile.am
rename test/validation/{odp_pktio.c => pktio/pktio.c} (90%)
create mode 100644 test/validation/pktio/pktio.h
create mode 100644 test/validation/pktio/pktio_main.c
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
