Please ignore this one (just posted v2). I broke the indentation while trying to understand the warning message :)
On 06/09/2015 10:06 AM, Nicolas Morey-Chaisemartin wrote: > On some systems, char is mapped to unsigned char which causes gcc to issue > this warning: > test/validation/ver_abt_log_dbg/odp_system.c:23:7: error: array subscript has > type ‘char’ [-Werror=char-subscripts] > Manually casting from char to int should fix issue on both (signed or > unsigned) types of system > > Signed-off-by: Nicolas Morey-Chaisemartin <nmo...@kalray.eu> > --- > test/validation/ver_abt_log_dbg/odp_system.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/test/validation/ver_abt_log_dbg/odp_system.c > b/test/validation/ver_abt_log_dbg/odp_system.c > index 1a40957..128ae36 100644 > --- a/test/validation/ver_abt_log_dbg/odp_system.c > +++ b/test/validation/ver_abt_log_dbg/odp_system.c > @@ -19,7 +19,8 @@ static void test_odp_version_numbers(void) > sizeof(version_string)-1); > > while (*s) { > - if (isdigit(*s) || (strncmp(s, ".", 1) == 0)) { > + if ( > + isdigit((int)*s) || (strncmp(s, ".", 1) == 0)) { > char_ok = 1; > s++; > } else { > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp _______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp