Maybe I can do it the other way around and put the common flags in the platform/<plat>/test/Makefile.am
The idea is to have a single place where automake test flags can be changed. This is linked to my EXEEXT patch as we need to specify run commands (xxx_LOG_COMPILER) depending on the file extension (host script, JTAG runner, H/W simulators, etc..) On 07/03/2015 01:25 PM, Christophe Milard wrote: > > > On 3 July 2015 at 11:52, Maxim Uvarov <maxim.uva...@linaro.org > <mailto:maxim.uva...@linaro.org>> wrote: > > CC Anders for build patches. > > Maxim. > > > On 06/30/15 10:24, Nicolas Morey-Chaisemartin wrote: > > Signed-off-by: Nicolas Morey-Chaisemartin <nmo...@kalray.eu > <mailto:nmo...@kalray.eu>> > --- > helper/test/Makefile.am | 2 +- > platform/linux-generic/test/Makefile.am | 3 ++- > test/Makefile.inc | 2 ++ > test/performance/Makefile.am | 2 +- > 4 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/helper/test/Makefile.am b/helper/test/Makefile.am > index 9ac82eb..4e437ec 100644 > --- a/helper/test/Makefile.am > +++ b/helper/test/Makefile.am > @@ -3,7 +3,7 @@ include $(top_srcdir)/test/Makefile.inc > AM_CFLAGS += -I$(srcdir)/common > AM_LDFLAGS += -static > -TESTS_ENVIRONMENT = ODP_PLATFORM=${with_platform} > TEST_DIR=${builddir} > +TESTS_ENVIRONMENT += TEST_DIR=${builddir} > EXECUTABLES = odp_chksum$(EXEEXT) \ > odp_thread$(EXEEXT) \ > diff --git a/platform/linux-generic/test/Makefile.am > b/platform/linux-generic/test/Makefile.am > index 0ef1c44..c063295 100644 > --- a/platform/linux-generic/test/Makefile.am > +++ b/platform/linux-generic/test/Makefile.am > @@ -1,4 +1,5 @@ > -TESTS_ENVIRONMENT = TEST_DIR=${top_builddir}/test/validation > +include $(top_srcdir)/test/Makefile.inc > +TESTS_ENVIRONMENT += TEST_DIR=${top_builddir}/test/validation > ODP_MODULES = pktio > diff --git a/test/Makefile.inc b/test/Makefile.inc > index 1eb6ed5..6cdd0db 100644 > --- a/test/Makefile.inc > +++ b/test/Makefile.inc > @@ -20,3 +20,5 @@ AM_LDFLAGS += -L$(LIB) > @VALGRIND_CHECK_RULES@ > valgrind_tools = memcheck drd sgcheck > + > +TESTS_ENVIRONMENT= ODP_PLATFORM=${with_platform} > \ No newline at end of file > diff --git a/test/performance/Makefile.am > b/test/performance/Makefile.am > index fc37305..ae2973e 100644 > --- a/test/performance/Makefile.am > +++ b/test/performance/Makefile.am > @@ -1,6 +1,6 @@ > include $(top_srcdir)/test/Makefile.inc > -TESTS_ENVIRONMENT = TEST_DIR=${builddir} > ODP_PLATFORM=${with_platform} > +TESTS_ENVIRONMENT += TEST_DIR=${builddir} > EXECUTABLES = odp_atomic$(EXEEXT) odp_pktio_perf$(EXEEXT) > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > I am not sure I like ODP_PLATFORM beeing accessible from the validation side > again. > The idea is that everything under /test/validation should be platform > agnostic, and therefore should not use ODP_PLATFORM . > Platform dependant stuff should be gathered in the platform dependent part. > (currentely platform/<platform>/test. hopefully this will be moved in the > future) > > What are we trying to achieve with this patch? Is there something I miss? > > /Christophe. > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
