On 07/03/2015 12:22 PM, Maxim Uvarov wrote:
> On 07/03/15 10:05, Nicolas Morey-Chaisemartin wrote:
>>
>
> I really like that changes. They should simplify porting to new platform and 
> adding new pktio.
>
> Also we can think about moving all pktio files to 
> platform/linux-generic/pktio/  or directory, so that
> we can remove odp_packet_ prefix in all file names.
>
> I think it might be interesting to use dpdk way to include new pktio drivers. 
> I.e. the same thing like they do with PMD. Just
> link all pkio to library then walk thought symbols and find all available 
> "drivers", then register them. Because we reference to
> pktio by name, not by enum value it should work in our case. I.e. if we 
> implement code like that to add new pktio we even
> don't need to extend any internal enum.
>
> But change is fine for me.
>
> Maxim.
>
>
I was tweaking the patch and realise one thing: Wouldn't you need to tweak  
odp_packet_io_internal.h anyway to add a struct related to your pktio type in 
the pktio_entry definition?

Nicolas

_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to