On 15 September 2015 at 10:18, Ivan Khoronzhuk <ivan.khoronz...@linaro.org>
wrote:

> Hi, Hongbo
>
> Can it be built after this change? Should it be build-able at least?


All series should be build-able - if the check-odp  apply-and-build script
does not pass it cannot be committed.


>
>
> On 15.09.15 16:55, hongbo.zh...@freescale.com wrote:
>
>> From: Hongbo Zhang <hongbo.zh...@linaro.org>
>>
>> This patch moves odp_sys_cpu_model_str() to cpu.h, all the calling
>> functions will be updated in later separate patch.
>>
>> Signed-off-by: Hongbo Zhang <hongbo.zh...@linaro.org>
>> ---
>>   include/odp/api/cpu.h                    | 9 +++++++++
>>   include/odp/api/system_info.h            | 7 -------
>>   platform/linux-generic/odp_system_info.c | 2 +-
>>   3 files changed, 10 insertions(+), 8 deletions(-)
>>
>> diff --git a/include/odp/api/cpu.h b/include/odp/api/cpu.h
>> index c389093..78c3ffc 100644
>> --- a/include/odp/api/cpu.h
>> +++ b/include/odp/api/cpu.h
>> @@ -44,6 +44,15 @@ int odp_cpu_id(void);
>>   int odp_cpu_count(void);
>>
>>   /**
>> + * CPU model name of this CPU
>> + *
>> + * Returns the CPU model name of this CPU.
>> + *
>> + * @return Pointer to CPU model name string
>> + */
>> +const char *odp_cpu_model_str(void);
>> +
>> +/**
>>    * @}
>>    */
>>
>> diff --git a/include/odp/api/system_info.h b/include/odp/api/system_info.h
>> index e55ff6d..1cd883f 100644
>> --- a/include/odp/api/system_info.h
>> +++ b/include/odp/api/system_info.h
>> @@ -45,13 +45,6 @@ uint64_t odp_sys_huge_page_size(void);
>>   uint64_t odp_sys_page_size(void);
>>
>>   /**
>> - * CPU model name
>> - *
>> - * @return Pointer to CPU model name string
>> - */
>> -const char *odp_sys_cpu_model_str(void);
>> -
>> -/**
>>    * Cache line size in bytes
>>    *
>>    * @return CPU cache line size in bytes
>> diff --git a/platform/linux-generic/odp_system_info.c
>> b/platform/linux-generic/odp_system_info.c
>> index 83226f8..ed6b515 100644
>> --- a/platform/linux-generic/odp_system_info.c
>> +++ b/platform/linux-generic/odp_system_info.c
>> @@ -389,7 +389,7 @@ uint64_t odp_sys_page_size(void)
>>         return odp_global_data.system_info.page_size;
>>   }
>>
>> -const char *odp_sys_cpu_model_str(void)
>> +const char *odp_cpu_model_str(void)
>>   {
>>         return odp_global_data.system_info.model_str[0];
>>   }
>>
>>
> --
> Regards,
> Ivan Khoronzhuk
>



-- 
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to