I skipped this coz this as I just realised that since this was an error packet and it might not be required for platforms to parse an error packet and hence I removed the sequence number check for this packet and just checked whether this packet was received on error CoS queue.
Regards, Bala On 21 October 2015 at 16:50, Ivan Khoronzhuk <ivan.khoronz...@linaro.org> wrote: > Seems in last patch the following was added to test_pktio_error_cos(): > > + seqno = cls_pkt_get_seq(pkt); > + CU_ASSERT(seqno != TEST_SEQ_INVALID); > ... > + CU_ASSERT(seqno == cls_pkt_get_seq(pkt)); > > Why did you skip it here? > I expected patch with name "Align..." including this change. > > For this concrete change: > Reviewed-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> > > > On 21.10.15 08:14, Balasubramanian Manoharan wrote: >> >> check for invalid sequence number is performed during packet create and >> it is not required during packet receive >> >> Signed-off-by: Balasubramanian Manoharan <bala.manoha...@linaro.org> >> --- >> test/validation/classification/odp_classification_test_pmr.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/test/validation/classification/odp_classification_test_pmr.c >> b/test/validation/classification/odp_classification_test_pmr.c >> index c058caf..4bfe0cb 100644 >> --- a/test/validation/classification/odp_classification_test_pmr.c >> +++ b/test/validation/classification/odp_classification_test_pmr.c >> @@ -443,7 +443,6 @@ static void >> classification_test_pmr_term_udp_sport(void) >> >> pkt = receive_packet(&retqueue, ODP_TIME_SEC); >> CU_ASSERT(pkt != ODP_PACKET_INVALID); >> - CU_ASSERT(cls_pkt_get_seq(pkt) != TEST_SEQ_INVALID); >> CU_ASSERT(seqno == cls_pkt_get_seq(pkt)); >> CU_ASSERT(retqueue == defqueue); >> odp_packet_free(pkt); >> @@ -523,7 +522,6 @@ static void classification_test_pmr_term_ipproto(void) >> >> pkt = receive_packet(&retqueue, ODP_TIME_SEC); >> CU_ASSERT(pkt != ODP_PACKET_INVALID); >> - CU_ASSERT(cls_pkt_get_seq(pkt) != TEST_SEQ_INVALID); >> CU_ASSERT(seqno == cls_pkt_get_seq(pkt)); >> CU_ASSERT(retqueue == defqueue); >> >> > > -- > Regards, > Ivan Khoronzhuk _______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
