Hi, For all patches that modify API files (include/odp/api/xxx.h), patch naming should be: "[API-NEXT PATCH v2 1/4] api: crypto: ... "
So, words "PATCH" and "api:" are missing from the mail subject / git log entry. > -----Original Message----- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > EXT Nicolas Morey-Chaisemartin > Sent: Friday, November 06, 2015 10:38 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXTv2 1/4] crypto: move enums from platform > types to odp and rename to fit the API format > > Signed-off-by: Nicolas Morey-Chaisemartin <nmo...@kalray.eu> > --- > example/ipsec/odp_ipsec_cache.c | 2 +- > example/ipsec/odp_ipsec_cache.h | 4 +- > example/ipsec/odp_ipsec_misc.h | 4 +- > include/odp/api/crypto.h | 140 ++++++++++--- > -------- > .../linux-generic/include/odp/plat/crypto_types.h | 42 ------- > .../linux-generic/include/odp_crypto_internal.h | 12 +- > platform/linux-generic/odp_crypto.c | 29 +++-- > test/validation/crypto/odp_crypto_test_inp.c | 10 +- > 8 files changed, 93 insertions(+), 150 deletions(-) > > diff --git a/example/ipsec/odp_ipsec_cache.c > b/example/ipsec/odp_ipsec_cache.c > index 6a8f3c9..0883d4d 100644 > --- a/example/ipsec/odp_ipsec_cache.c > +++ b/example/ipsec/odp_ipsec_cache.c > @@ -46,7 +46,7 @@ int create_ipsec_cache_entry(sa_db_entry_t > *cipher_sa, > { > odp_crypto_session_params_t params; > ipsec_cache_entry_t *entry; > - enum odp_crypto_ses_create_err ses_create_rc; > + odp_crypto_ses_create_err_t ses_create_rc; > odp_crypto_session_t session; > sa_mode_t mode = IPSEC_SA_MODE_TRANSPORT; > > diff --git a/example/ipsec/odp_ipsec_cache.h > b/example/ipsec/odp_ipsec_cache.h > index 5706007..91d9d7e 100644 > --- a/example/ipsec/odp_ipsec_cache.h > +++ b/example/ipsec/odp_ipsec_cache.h > @@ -38,14 +38,14 @@ typedef struct ipsec_cache_entry_s { > uint32_t tun_src_ip; /**< Tunnel src IPv4 > addr */ > uint32_t tun_dst_ip; /**< Tunnel dst IPv4 > addr */ > struct { > - enum odp_cipher_alg alg; /**< Cipher algorithm */ > + odp_cipher_alg_t alg; /**< Cipher algorithm */ > uint32_t spi; /**< Cipher SPI */ > uint32_t block_len; /**< Cipher block length > */ > uint32_t iv_len; /**< Cipher IV length */ > ipsec_key_t key; /**< Cipher key */ > } esp; > struct { > - enum odp_auth_alg alg; /**< Auth algorithm */ > + odp_auth_alg_t alg; /**< Auth algorithm */ > uint32_t spi; /**< Auth SPI */ > uint32_t icv_len; /**< Auth ICV length */ > ipsec_key_t key; /**< Auth key */ > diff --git a/example/ipsec/odp_ipsec_misc.h > b/example/ipsec/odp_ipsec_misc.h > index f6a12b5..85c5f6a 100644 > --- a/example/ipsec/odp_ipsec_misc.h > +++ b/example/ipsec/odp_ipsec_misc.h > @@ -59,8 +59,8 @@ typedef struct { > typedef struct { > odp_bool_t cipher; > union { > - enum odp_cipher_alg cipher; > - enum odp_auth_alg auth; > + odp_cipher_alg_t cipher; > + odp_auth_alg_t auth; > } u; > } ipsec_alg_t; > > diff --git a/include/odp/api/crypto.h b/include/odp/api/crypto.h > index a9a2a1d..cc204a1 100644 > --- a/include/odp/api/crypto.h > +++ b/include/odp/api/crypto.h > @@ -39,51 +39,46 @@ extern "C" { > */ > > /** > - * @enum odp_crypto_op_mode > * Crypto API operation mode > - * > - * @enum odp_crypto_op_mode:ODP_CRYPTO_SYNC > - * Synchronous, return results immediately > - * > - * @enum odp_crypto_op_mode:ODP_CRYPTO_ASYNC > - * Aynchronous, return results via posted event > */ > +typedef enum { > + /** Synchronous, return results immediately */ > + ODP_CRYPTO_SYNC, > + /** Aynchronous, return results via posted event */ While updating patch names, this old typo could corrected also: "Asynchronous" -Petri > + ODP_CRYPTO_ASYNC, > +} odp_crypto_op_mode_t; > _______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp