On 20 November 2015 at 19:23, Maxim Uvarov <maxim.uva...@linaro.org> wrote:
> On 11/20/2015 20:07, Anders Roxell wrote:
>>
>> On 20 November 2015 at 15:45, Mike Holmes <mike.hol...@linaro.org> wrote:
>>>
>>> Do we have a review for this ?
>>
>> No because it didn't work due to we always depends on libssl-dev
>> (debian) or openssl-devel (fedora).
>>
>> This is the output if we have a buildserver that doesn't have any
>> pre-installed packages except for
>> the standard, gcc, make, autotools:
>> checking for joinable pthread attribute... PTHREAD_CREATE_JOINABLE
>> checking if more special flags are required for pthreads... no
>> checking for PTHREAD_PRIO_INHERIT... yes
>> checking for EVP_EncryptInit in -lcrypto... no
>> configure: error: in `/odp':
>> configure: error: OpenSSL libraries required
>> See `config.log' for more details
>>
>>
>> So it makes more sense to update the CI build servers to do the correct
>> thing.
>>
>> That's why I think this patch should be reverted.
>>
>> Cheers,
>> Anders
>
> I tested that and it generated correct tar.gz.
We both agree that this patch generates a tar.gz file.
> What is relation between that
> patch and libssl-dev?
The changelog states that you can generate the source package without
installing the build-deps right, and libssl-dev is that a build dependency?
I would say yes!
> Patch just adds "source" argument to build source. It does not modify any
> dependencies.
> In my case ./builddeb source works, and without source it's the same
> behaviour as original.
> I think you log is not related to that patch.
And my log shows what happens if you _NOT_ install any build dependencies that
is stated in the control file.
Cheers,
Anders
>
> Maxim.
>
>
>
>
>>
>>> On 20 November 2015 at 09:39, Maxim Uvarov <maxim.uva...@linaro.org>
>>> wrote:
>>>>
>>>> Merged,
>>>> Maxim.
>>>>
>>>>
>>>> On 11/19/2015 09:35, Riku Voipio wrote:
>>>>>
>>>>> For CI loop, we have separate job to build binaries (build-package).
>>>>> To make it possible to build source package without first installing
>>>>> all build-deps, add a new optional parameter "source" to build
>>>>> only source package.
>>>>>
>>>>> Signed-off-by: Riku Voipio <riku.voi...@linaro.org>
>>>>> ---
>>>>> scripts/builddeb | 7 ++++++-
>>>>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/scripts/builddeb b/scripts/builddeb
>>>>> index 829fd1d..28927ea 100755
>>>>> --- a/scripts/builddeb
>>>>> +++ b/scripts/builddeb
>>>>> @@ -23,6 +23,11 @@ if [ $(egrep "\.([a-z0-9]{8}\>|dirty)" .scmversion
>>>>> |wc
>>>>> -l) -gt 0 ]; then
>>>>> dch --newversion ${version}-1 --urgency low "not a official
>>>>> release!"
>>>>> fi
>>>>> -debuild -us -uc
>>>>> +if [ "$1" = source ]
>>>>> +then
>>>>> + dpkg-buildpackage -S -d
>>>>> +else
>>>>> + debuild -us -uc
>>>>> +fi
>>>>> popd
>>>>> popd
>>>>
>>>>
>>>> _______________________________________________
>>>> lng-odp mailing list
>>>> lng-odp@lists.linaro.org
>>>> https://lists.linaro.org/mailman/listinfo/lng-odp
>>>
>>>
>>>
>>>
>>> --
>>> Mike Holmes
>>> Technical Manager - Linaro Networking Group
>>> Linaro.org │ Open source software for ARM SoCs
>>>
>>>
>>>
>>> _______________________________________________
>>> lng-odp mailing list
>>> lng-odp@lists.linaro.org
>>> https://lists.linaro.org/mailman/listinfo/lng-odp
>>>
>
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
