On 20 November 2015 at 13:41, Maxim Uvarov <maxim.uva...@linaro.org> wrote:

> Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org>
> ---
>  platform/linux-generic/Makefile.am                 |   4 +
>  .../linux-generic/include/odp_buffer_internal.h    |   3 +
>  .../linux-generic/include/odp_packet_io_internal.h |  38 ++
>  .../include/odp_packet_io_ipc_internal.h           |  47 ++
>  platform/linux-generic/include/odp_shm_internal.h  |  21 +
>  platform/linux-generic/odp_packet_io.c             |   1 +
>  platform/linux-generic/odp_pool.c                  |  14 +-
>  platform/linux-generic/odp_shared_memory.c         |  14 +-
>  platform/linux-generic/pktio/io_ops.c              |   1 +
>  platform/linux-generic/pktio/ipc.c                 | 729
> +++++++++++++++++++++
>  platform/linux-generic/pktio/ring.c                |   1 +
>  11 files changed, 868 insertions(+), 5 deletions(-)
>  create mode 100644
> platform/linux-generic/include/odp_packet_io_ipc_internal.h
>  create mode 100644 platform/linux-generic/include/odp_shm_internal.h
>  create mode 100644 platform/linux-generic/pktio/ipc.c
>  create mode 120000 platform/linux-generic/pktio/ring.c
>

The file ring.c is a symlink, we dont want the functions defined in odph_*
in linux-generic. We dont want these functions in two libraries and we dont
want to force platforms reusing linux-generic to be forced to meet these
new dependencies on the helpers code such as  #include "odph_debug.h"

---

In my opinion helpers is already an ugly mix of code to help three
different use cases:

   - applications
   - linux-generic
   - support test framework

The linux-generic implementation should not depend helpers.

--
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to