On 30.11.15 16:07, Savolainen, Petri (Nokia - FI/Espoo) wrote:
-----Original Message----- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Ivan Khoronzhuk Sent: Monday, November 23, 2015 11:21 PM To: lng-odp@lists.linaro.org Subject: [lng-odp] [API-NEXT PATCH v3 6/7] api: time: make odp_local_time to be monotonic wall time It's more convenient the local time to be a monotonic wall time. That means time starts from 0 and not wraps. It allows to use local time in similar manner as it's supposed to be used with global time and the 64-bit timer is enough to guarantee it. Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org>diff --git a/include/odp/api/time.h b/include/odp/api/time.h index 50a0bf5..9865d81 100644 --- a/include/odp/api/time.h +++ b/include/odp/api/time.h @@ -45,7 +45,8 @@ extern "C" { * Current local time * * Returns current local time stamp value. The local time source provides high - * resolution time. + * resolution time, it is initialized to zero during ODP startup and will not + * wrap around in at least 10 years. * * @return Local time stamp. */I think it's better to separate this the API spec into its own patch. All other changes here may or may not depend on it, but those can follow in the next patch. It's significant spec change and an implementer may miss it now.
Ok. I will split it on linux-generic + api and examples/testes patches. But I think this simplification is not very eficient as api change patch will contain: include/odp/api/time.h | 3 +- platform/linux-generic/include/odp_internal.h | 2 + platform/linux-generic/odp_schedule.c | 9 ++-- platform/linux-generic/odp_time.c | 61 +++++++++++++++++++-------- and example/test patch: example/generator/odp_generator.c | 10 ++--- test/performance/odp_pktio_perf.c | 26 ++++++------ test/validation/pktio/pktio.c | 21 ++++-----
-Petri
-- Regards, Ivan Khoronzhuk _______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
