Maxim,
I've corrected the defects in v7.
Please, merge.
On 04.12.15 11:36, Maxim Uvarov wrote:
Hello Ivan,
The hole patch set looks like good. But it looks like patch order is wrong or
some patches needs to be merged.
If I apply only 8 patches there is error:
Test: time_test_odp_negative_diff ...FAILED
1. time.c:42 - odp_time_cmp(diff, ODP_TIME_NULL) > 0
If only 7 patches then odp_pktio_perf test fails.
Also running odp-check I saw segfault on some patches.
And patches short message is: "[API-NEXT PATCH v6] 0/9]", but it has to be [API-NEXT
PATCHv6 0/9]".
Maxim.
On 12/03/2015 17:07, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Entire patch set:
Reviewed-by: Petri Savolainen <petri.savolai...@nokia.com>
-----Original Message-----
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
Ivan Khoronzhuk
Sent: Thursday, December 03, 2015 2:49 PM
To: lng-odp@lists.linaro.org
Subject: [lng-odp] [API-NEXT PATCH v6] 0/9] api: time: update local time
to be monotonic
This series is intended to modify time API to be used as monotonic wall
time in order to simplify time API usage and create prerequisites for
adding global time API.
Since v5
linux-generic: align with new wall time API
- deleted _odp prefix for local functions
- avoided modulo operation
- used common global var for start time
Since v3:
- "api: time: make odp_local_time to be monotonic wall time"
splitted on;
"linux-generic: align with new wall time API"
"test/example: use local time API as wall time"
- increased BUSY_LOOP_CNT to fit in resolution and 4+ sec
Since v2:
- removed patch changing type of ODP_TIME_*
- added new patch:
test: performance: pktio: don't use direct arithmetic operations with
odp_time_t
- added new patch:
performance: sched: use ODP time API instead of clock_gettime
- combined monotonic and wall time patches
- removed odp_time_local_val() and odp_time_val_to_ns()
- replaced terms monotonic and wall in API desc
Since v1:
- corrected name of the series to be api-next
- use thread local for holding start time
Ivan Khoronzhuk (9):
validation: time: don't assign int directly to odp_time_t
test: performance: pktio: don't use direct arithmetic operations with
odp_time_t
linux-generic: schedule: use schedule time in ns
linux-generic: odp_time: don't use cpu cycle API to get time
performance: sched: use ODP time API instead of clock_gettime
api: time: make odp_local_time to be monotonic wall time
linux-generic: align with new wall time API
test/example: use local time API as wall time
validation: time: align tests with current time API
example/generator/odp_generator.c | 10 +-
include/odp/api/time.h | 3 +-
platform/linux-generic/Makefile.am | 1 -
.../linux-generic/include/odp/plat/time_types.h | 6 +-
platform/linux-generic/include/odp_cpu_internal.h | 29 ---
platform/linux-generic/include/odp_internal.h | 2 +
platform/linux-generic/odp_cpu.c | 6 +-
platform/linux-generic/odp_init.c | 4 +
platform/linux-generic/odp_schedule.c | 18 +-
platform/linux-generic/odp_time.c | 112 +++++++---
test/performance/odp_pktio_perf.c | 24 +--
test/performance/odp_scheduling.c | 37 +---
test/validation/pktio/pktio.c | 21 +-
test/validation/time/time.c | 228
++++++++++++++++++---
test/validation/time/time.h | 7 +-
15 files changed, 346 insertions(+), 162 deletions(-)
delete mode 100644 platform/linux-generic/include/odp_cpu_internal.h
--
1.9.1
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
--
Regards,
Ivan Khoronzhuk
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
