On 8 December 2015 at 10:49, Stuart Haslam <stuart.has...@linaro.org> wrote:
> On Thu, Dec 03, 2015 at 08:39:26AM -0500, Mike Holmes wrote:
> > It does miss it apparently - just shows you we still need a human eye
> >
>
> I have this in my ~/.gitconfig
> [core]
> whitespace = trailing-space,space-before-tab,indent-with-non-tab
>
I had whitespace = trailing-space,sapce-before-tab,error-all
Thanks for pointer I had typo and a missing setting, I will send a patch to
the contributing section for the settings once I check what we want in a
little more detail
>
> and it warns about it:
>
> Applying: helper: table: add impl of hashtable
> odp/.git/rebase-apply/patch:361: new blank line at EOF.
> +
> odp/.git/rebase-apply/patch:409: new blank line at EOF.
> +
> odp/.git/rebase-apply/patch:500: new blank line at EOF.
> +
> warning: 3 lines add whitespace errors.
>
> --
> Stuart.
>
> > mike@mike-desktop:~/git/odp$ git format-patch -1 a775afd
> > 0001-helper-table-add-impl-of-hashtable.patch
> > mike@mike-desktop:~/git/odp$ ./scripts/checkpatch.pl
> > 0001-helper-table-add-impl-of-hashtable.patch
> > total: 0 errors, 0 warnings, 0 checks, 473 lines checked
> >
> > NOTE: Ignored message types: COMPARISON_TO_NULL DEPRECATED_VARIABLE
> > NEW_TYPEDEFS SPLIT_STRING
> >
> > 0001-helper-table-add-impl-of-hashtable.patch has no obvious style
> problems
> > and is ready for submission.
> >
> >
> > On 3 December 2015 at 08:16, Ivan Khoronzhuk <ivan.khoronz...@linaro.org
> >
> > wrote:
> >
> > >
> > >
> > > On 05.11.15 13:20, huanggaoyang wrote:
> > >
> > >> Signed-off-by: huanggaoyang <huanggaoya...@huawei.com>
> > >> ---
> > >> helper/hashtable.c | 346
> > >> ++++++++++++++++++++++++++++++++++++++++++++
> > >> helper/odph_hashtable.h | 42 ++++++
> > >> helper/odph_list_internal.h | 85 +++++++++++
> > >> 3 files changed, 473 insertions(+)
> > >> create mode 100644 helper/hashtable.c
> > >> create mode 100644 helper/odph_hashtable.h
> > >> create mode 100644 helper/odph_list_internal.h
> > >>
> > >> diff --git a/helper/hashtable.c b/helper/hashtable.c
> > >> new file mode 100644
> > >> index 0000000..0b29814
> > >> --- /dev/null
> > >> +++ b/helper/hashtable.c
> > >> @@ -0,0 +1,346 @@
> > >> +/* Copyright (c) 2015, Linaro Limited
> > >> + * All rights reserved.
> > >> + *
> > >> + * SPDX-License-Identifier: BSD-3-Clause
> > >> + */
> > >> +#include <stdio.h>
> > >> +#include <string.h>
> > >> +#include <malloc.h>
> > >> +
> > >> +#include "odph_hashtable.h"
> > >> +#include "odph_list_internal.h"
> > >> +#include "odph_debug.h"
> > >> +#include <odp.h>
> > >> +
> > >> +#define ODPH_SUCCESS 0
> > >> +#define ODPH_FAIL -1
> > >> +
> > >>
> > > .....
> > >
> > >> +odph_table_ops_t odph_hash_table_ops = {
> > >> + odph_hash_table_create,
> > >> + odph_hash_table_lookup,
> > >> + odph_hash_table_destroy,
> > >> + odph_hash_put_value,
> > >> + odph_hash_get_value,
> > >> + odph_hash_remove_value};
> > >> +
> > >>
> > >
> > > ....
> > > Blank line at the end of file.
> > > Need to add check in checkpatch.
> > >
> > > --
> > > Regards,
> > > Ivan Khoronzhuk
> > > _______________________________________________
> > > lng-odp mailing list
> > > lng-odp@lists.linaro.org
> > > https://lists.linaro.org/mailman/listinfo/lng-odp
> > >
> >
> >
> >
> > --
> > Mike Holmes
> > Technical Manager - Linaro Networking Group
> > Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM
> SoCs
>
>
--
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
