On 02/17/16 10:43, Savolainen, Petri (Nokia - FI/Espoo) wrote:
##############################################################
############
netmap_support=no
+pktio_ipc_support=no
We should probably choose a common naming scheme for these variables.
'pktio_<type>_support' sounds OK to me.
##############################################################
############
# Run platform specific checks and settings
@@ -102,7 +103,7 @@ fi
##############################################################
############
AM_CONDITIONAL([netmap_support], [test x$netmap_support = xyes ])
AM_CONDITIONAL([HAVE_PCAP], [test $have_pcap = yes])
The variable naming convention should be harmonized. E.g. above we have "have_pcap" defined in both
lower and upper case. Also "xnetmap_support" is set to "xyes" ?? Are all these variables
(with and without x) needed ?
I'd suggest to define makefile variables in upper case and use PKTIO_ prefix
for all these variables (e.g. PKTIO_NETMAP, PKTIO_NETMAP_XYZ, ...) which select
various pktio options.
-Petri
Let's do that harmonization in separate patch. There are bunch of other
places and it will be more easy to review all renaming in one patch.
Maxim.
-
+AM_CONDITIONAL([pktio_ipc_support], [test x$pktio_ipc_support = yes])
Same thing as above. AM_CONDITIONAL naming convention seems to be all
caps. I'm
currently working on a similar patch for DPDK, so I'd like to use the same
naming scheme.
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
