> -----Original Message----- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Maxim Uvarov > Sent: Thursday, February 18, 2016 10:45 AM > To: Elo, Matias (Nokia - FI/Espoo) <matias....@nokia.com>; lng- > o...@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCHv3 1/2] linux-generic: pktio: add > option to enable and disable ipc pktio > > Hello Matias, > > thanks for comments will send v4. > > During update I thinge we can not use ODP_ prefix here: > +#ifdef ODP_PKTIO_IPC > &ipc_pktio_ops, > +#endif > > as well as in: > > +#ifdef ODP_PKTIO_DPDK > .... > +#endif > > Because it might be confusing other people thinking that it's related to > some odp API. > > Let's use simple PKTIO_IPC, PKTIO_DPDK, PKTIO_NETMAP and etc. Agree?
I think it's better to prefix. Could use _ODP_PKTIO_IPC, ... so that it's clearly internal to the implementation. -Petri _______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
