Ok. I'll send a v2 with atht typo fixed and your reviewed message, if that is OK with you.
On 2 March 2016 at 14:31, Bill Fischofer <bill.fischo...@linaro.org> wrote: > Ah, OK. That wasn't obvious, so ignore my issue 2: > > For this series: > > Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.org> > > On Wed, Mar 2, 2016 at 7:30 AM, Christophe Milard < > christophe.mil...@linaro.org> wrote: > >> shmem_odp should not be run alone: it is forked and execv'd by shmem >> linux. If you run make check, only shmem_linux is actually called: >> shmem_linux forks and execv shmem_odp.... and makes sure it see the shared >> memory. >> The comment at the beginning of shmem_linux.c explains it all... >> hopefully :-) >> >> On 2 March 2016 at 14:27, Bill Fischofer <bill.fischo...@linaro.org> >> wrote: >> >>> Sorry, my bad. I forgot about --enable-test-vald >>> >>> When I add that then the tests build properly, so ignore my point 1. >>> >>> However, while shmem_linux runs and passes, shmem_odp still hangs. >>> >>> On Wed, Mar 2, 2016 at 7:19 AM, Christophe Milard < >>> christophe.mil...@linaro.org> wrote: >>> >>>> Make shmem_odp will hang alone: it needs its linux counterpart. Make >>>> should fix that for you. I assume as soon as we sort out why you have this >>>> make problme, it will work better. >>>> And I have noticed the typo in the second patch title ODP_SHM_PROP >>>> should be ODP_SHM_PROC. will be fix in v2 with your other comments :-) >>>> >>>> Many thanks for looking at it! >>>> >>>> On 2 March 2016 at 14:06, Christophe Milard < >>>> christophe.mil...@linaro.org> wrote: >>>> >>>>> shouldn't you have --enable-test-vald as well? >>>>> >>>>> If I run: >>>>> >>>>> ./bootstrap && ./configure >>>>> --with-cunit-path=/home/erachmi/linaro/ODP/check-odp/installed/x86_64/cunit-2.1-3 >>>>> --enable-test-vald && make -j 8 && make check >>>>> >>>>> I get: >>>>> ... >>>>> make[3]: Entering directory >>>>> '/home/erachmi/linaro/ODP/odp/platform/linux-generic/test' >>>>> make[4]: Entering directory >>>>> '/home/erachmi/linaro/ODP/odp/platform/linux-generic/test' >>>>> PASS: pktio/pktio_run >>>>> SKIP: pktio/pktio_run_tap >>>>> *PASS: shmem/shmem_linux* >>>>> PASS: ../../../test/validation/atomic/atomic_main >>>>> PASS: ../../../test/validation/barrier/barrier_main >>>>> ... >>>>> are you using --enable-test-vald ? >>>>> >>>>> >>>>> On 2 March 2016 at 13:40, Bill Fischofer <bill.fischo...@linaro.org> >>>>> wrote: >>>>> >>>>>> I failed to notice the pre-req. However after applying that patch I >>>>>> see the same behavior. >>>>>> >>>>>> ./bootstrap >>>>>> ./configure --enable-cunit-support >>>>>> make >>>>>> >>>>>> Result: nothing built in platforms/linux-generic/test/shmem >>>>>> >>>>>> If I go into that directory and type make then shmem_odp is built, >>>>>> but when I try to run it it hangs. >>>>>> >>>>>> On Wed, Mar 2, 2016 at 6:32 AM, Christophe Milard < >>>>>> christophe.mil...@linaro.org> wrote: >>>>>> >>>>>>> Hi Bill >>>>>>> thanks for looking At it: >>>>>>> I guess (hope) that point 2 is because the patch scoping shmem has >>>>>>> not been merged yet (see first line of the cover letter). If you do have >>>>>>> applied this patch, then I don't understand. (please confirm). >>>>>>> I am very confused about point 1): I had a long fight with >>>>>>> autotools, but it seems to work for me now. what make command do you >>>>>>> use? >>>>>>> >>>>>>> On 2 March 2016 at 13:13, Bill Fischofer <bill.fischo...@linaro.org> >>>>>>> wrote: >>>>>>> >>>>>>>> Two problems: >>>>>>>> >>>>>>>> 1. After applying this patch make doesn't make this test (Make >>>>>>>> infrastructure needs updating) >>>>>>>> >>>>>>>> 2. If I manually make the test, running it seems to hang. Haven't >>>>>>>> investigated further. >>>>>>>> >>>>>>>> On Tue, Mar 1, 2016 at 10:34 AM, Christophe Milard < >>>>>>>> christophe.mil...@linaro.org> wrote: >>>>>>>> >>>>>>>>> (Note: requires: linux-generic: shmem: odp scope in /dev/shmem) >>>>>>>>> Adding a platform side test to test sharing memory between ODP and >>>>>>>>> linux. >>>>>>>>> This test is more interresting for its side effects: >>>>>>>>> *first complete test on the platform side building ODP and platform >>>>>>>>> programs (other platform tests so far were just wrappers to >>>>>>>>> generic >>>>>>>>> platform-agnostic test) >>>>>>>>> *tests that the shared memory device name (under /dev/shm/) is >>>>>>>>> scoped >>>>>>>>> (under linux). >>>>>>>>> >>>>>>>>> Christophe Milard (2): >>>>>>>>> linux-generic: test: adding odp includes >>>>>>>>> linux-generic: test: ODP_SHM_PROP test >>>>>>>>> >>>>>>>>> platform/linux-generic/m4/configure.m4 | 1 + >>>>>>>>> platform/linux-generic/test/Makefile.am | 4 +- >>>>>>>>> platform/linux-generic/test/Makefile.inc | 16 +++ >>>>>>>>> platform/linux-generic/test/shmem/.gitignore | 2 + >>>>>>>>> platform/linux-generic/test/shmem/Makefile.am | 18 +++ >>>>>>>>> platform/linux-generic/test/shmem/shmem.h | 21 +++ >>>>>>>>> platform/linux-generic/test/shmem/shmem_common.h | 23 ++++ >>>>>>>>> platform/linux-generic/test/shmem/shmem_linux.c | 156 >>>>>>>>> +++++++++++++++++++++++ >>>>>>>>> platform/linux-generic/test/shmem/shmem_linux.h | 9 ++ >>>>>>>>> platform/linux-generic/test/shmem/shmem_odp.c | 74 +++++++++++ >>>>>>>>> platform/linux-generic/test/shmem/shmem_odp.h | 7 + >>>>>>>>> 11 files changed, 330 insertions(+), 1 deletion(-) >>>>>>>>> create mode 100644 platform/linux-generic/test/Makefile.inc >>>>>>>>> create mode 100644 platform/linux-generic/test/shmem/.gitignore >>>>>>>>> create mode 100644 platform/linux-generic/test/shmem/Makefile.am >>>>>>>>> create mode 100644 platform/linux-generic/test/shmem/shmem.h >>>>>>>>> create mode 100644 >>>>>>>>> platform/linux-generic/test/shmem/shmem_common.h >>>>>>>>> create mode 100644 platform/linux-generic/test/shmem/shmem_linux.c >>>>>>>>> create mode 100644 platform/linux-generic/test/shmem/shmem_linux.h >>>>>>>>> create mode 100644 platform/linux-generic/test/shmem/shmem_odp.c >>>>>>>>> create mode 100644 platform/linux-generic/test/shmem/shmem_odp.h >>>>>>>>> >>>>>>>>> -- >>>>>>>>> 2.1.4 >>>>>>>>> >>>>>>>>> _______________________________________________ >>>>>>>>> lng-odp mailing list >>>>>>>>> lng-odp@lists.linaro.org >>>>>>>>> https://lists.linaro.org/mailman/listinfo/lng-odp >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> >
_______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
