On 15 April 2016 at 14:11, Ricardo Salveti <[email protected]> wrote:
> On Fri, Apr 15, 2016 at 1:45 PM, Mike Holmes <[email protected]> > wrote: > > As we approach a production stable release and we package for > > distribution inclusion, the default debug should be for the majority of > > users to build a performance image rather than a debug one. > > > > Signed-off-by: Mike Holmes <[email protected]> > > --- > > configure.ac | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/configure.ac b/configure.ac > > index 9665d1d..a10e0f6 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -156,10 +156,12 @@ DX_INIT_DOXYGEN($PACKAGE_NAME, > ${srcdir}/doc/application-api-guide/doxygen.cfg, > > > ########################################################################## > > # Enable/disable ODP_DEBUG_PRINT > > > ########################################################################## > > -ODP_DEBUG_PRINT=1 > > +ODP_DEBUG_PRINT=0 > > AC_ARG_ENABLE([debug-print], > > [ --enable-debug-print display debugging information], > > - [if ! test "x$enableval" = "xyes"; then > > + [if test "x$enableval" = "xyes"; then > > + ODP_DEBUG_PRINT=1 > > + else > > ODP_DEBUG_PRINT=0 > > fi]) > > ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG_PRINT=$ODP_DEBUG_PRINT" > > There is just no need for the else statemente, since the default is > already 0. > When you change the default again as I just did from 1, you will now be safe even if you forget to change the logic here, there is no performance penalty during configure. > Same for the other patch for ODP_DEBUG. > > Cheers, > -- > Ricardo Salveti > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
_______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
