Direct pthreads and process helpers should not be removed. Although our validation tests and examples need to be thread type agnostic, there are a bunch of other applications that will want to use either Linux pthread or process (not opaque threads).
Tests should be added for direct pthread/process helpers, instead of removing those. -Petri > -----Original Message----- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Mike > Holmes > Sent: Monday, May 02, 2016 2:47 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH] helper: remove unused odph_linux_process_fork > API > > odph_linux_process_fork is not used by any ODP example or test, it is also > untested by the helper test suite. > > odph_linux_process_fork is a wrapper for odph_linux_process_fork_n so > just delete this, the impact if there are any users is very small. > > Signed-off-by: Mike Holmes <mike.hol...@linaro.org> > --- > helper/include/odp/helper/linux.h | 18 ------------------ > helper/linux.c | 10 ---------- > 2 files changed, 28 deletions(-) > > diff --git a/helper/include/odp/helper/linux.h > b/helper/include/odp/helper/linux.h > index 7a6504f..a68f269 100644 > --- a/helper/include/odp/helper/linux.h > +++ b/helper/include/odp/helper/linux.h > @@ -80,24 +80,6 @@ int odph_linux_pthread_create(odph_linux_pthread_t > *pthread_tbl, > */ > void odph_linux_pthread_join(odph_linux_pthread_t *thread_tbl, int num); > > - > -/** > - * Fork a process > - * > - * Forks and sets CPU affinity for the child process. Ignores 'start' and > 'arg' > - * thread parameters. > - * > - * @param[out] proc Pointer to process state info (for output) > - * @param cpu Destination CPU for the child process > - * @param thr_params Linux helper thread parameters > - * > - * @return On success: 1 for the parent, 0 for the child > - * On failure: -1 for the parent, -2 for the child > - */ > -int odph_linux_process_fork(odph_linux_process_t *proc, int cpu, > - const odph_linux_thr_params_t *thr_params); > - > - > /** > * Fork a number of processes > * > diff --git a/helper/linux.c b/helper/linux.c > index 24e243b..a181322 100644 > --- a/helper/linux.c > +++ b/helper/linux.c > @@ -183,16 +183,6 @@ int odph_linux_process_fork_n(odph_linux_process_t > *proc_tbl, > return 1; > } > > -int odph_linux_process_fork(odph_linux_process_t *proc, int cpu, > - const odph_linux_thr_params_t *thr_params) > -{ > - odp_cpumask_t mask; > - > - odp_cpumask_zero(&mask); > - odp_cpumask_set(&mask, cpu); > - return odph_linux_process_fork_n(proc, &mask, thr_params); > -} > - > int odph_linux_process_wait_n(odph_linux_process_t *proc_tbl, int num) > { > pid_t pid; > -- > 2.7.4 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp _______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
