Wait, the final result is good and matches the long report - all the .sh
files pass but if you scroll back up I get

make[5]: Leaving directory
'/root/check-odp/build/odp/platform/linux-generic/test/shmem'
make[5]: Entering directory
'/root/check-odp/build/odp/platform/linux-generic/test'
make[5]: *** No rule to make target '--mode=execute', needed by 'all-am'.
make[5]: *** No rule to make target 'valgrind', needed by 'all-am'.
make[5]: *** No rule to make target '--error-exitcode=1', needed by
'all-am'.
make[5]: *** No rule to make target '--num-callers=30', needed by 'all-am'.
make[5]: Target 'all-am' not remade because of errors.
make[5]: Leaving directory
'/root/check-odp/build/odp/platform/linux-generic/test'
Makefile:707: recipe for target 'all-recursive' failed
make[4]: *** [all-recursive] Error 1
make[4]: Target 'all' not remade because of errors.
make[4]: Leaving directory
'/root/check-odp/build/odp/platform/linux-generic/test'


On 17 May 2016 at 12:00, Mike Holmes <mike.hol...@linaro.org> wrote:

>
>
> On 17 May 2016 at 11:14, Maxim Uvarov <maxim.uva...@linaro.org> wrote:
>
>> On 05/17/16 17:57, Maxim Uvarov wrote:
>>
>>> valgrind should not check bash wrappers. Accoding to doc:
>>>
>>> https://www.gnu.org/software/gnulib/manual/html_node/Running-self_002dtests-under-valgrind.html
>>> TEST_EXTENSIONS has to be set.
>>> https://bugs.linaro.org/show_bug.cgi?id=2230
>>>
>> this is for bug:
>> https://bugs.linaro.org/show_bug.cgi?id=2229
>>
>> will fix it on apply or v2 if it will be needed.
>
>
> Reviewed-and-tested-by: Mike Holmes <mike.hol...@linaro.org>
>
>
>>
>>
>> Maxim.
>>
>>
>>
>> Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org>
>>> ---
>>>   platform/linux-generic/test/Makefile.am                    | 14
>>> ++++++++------
>>>   platform/linux-generic/test/pktio/Makefile.am              | 10
>>> +++++-----
>>>   .../linux-generic/test/pktio/{pktio_run => pktio_run.sh}   |  0
>>>   .../test/pktio/{pktio_run_dpdk => pktio_run_dpdk.sh}       |  0
>>>   .../test/pktio/{pktio_run_netmap => pktio_run_netmap.sh}   |  0
>>>   .../test/pktio/{pktio_run_pcap => pktio_run_pcap.sh}       |  0
>>>   .../test/pktio/{pktio_run_tap => pktio_run_tap.sh}         |  0
>>>   platform/linux-generic/test/pktio_ipc/Makefile.am          |  2 +-
>>>   .../test/pktio_ipc/{pktio_ipc_run => pktio_ipc_run.sh}     |  0
>>>   test/performance/Makefile.am                               |  6 ++++--
>>>   test/performance/{odp_l2fwd_run => odp_l2fwd_run.sh}       |  0
>>>   .../{odp_scheduling_run => odp_scheduling_run.sh}          |  0
>>>   12 files changed, 18 insertions(+), 14 deletions(-)
>>>   rename platform/linux-generic/test/pktio/{pktio_run => pktio_run.sh}
>>> (100%)
>>>   rename platform/linux-generic/test/pktio/{pktio_run_dpdk =>
>>> pktio_run_dpdk.sh} (100%)
>>>   rename platform/linux-generic/test/pktio/{pktio_run_netmap =>
>>> pktio_run_netmap.sh} (100%)
>>>   rename platform/linux-generic/test/pktio/{pktio_run_pcap =>
>>> pktio_run_pcap.sh} (100%)
>>>   rename platform/linux-generic/test/pktio/{pktio_run_tap =>
>>> pktio_run_tap.sh} (100%)
>>>   rename platform/linux-generic/test/pktio_ipc/{pktio_ipc_run =>
>>> pktio_ipc_run.sh} (100%)
>>>   rename test/performance/{odp_l2fwd_run => odp_l2fwd_run.sh} (100%)
>>>   rename test/performance/{odp_scheduling_run => odp_scheduling_run.sh}
>>> (100%)
>>>
>>> diff --git a/platform/linux-generic/test/Makefile.am
>>> b/platform/linux-generic/test/Makefile.am
>>> index 05998e3..f74185d 100644
>>> --- a/platform/linux-generic/test/Makefile.am
>>> +++ b/platform/linux-generic/test/Makefile.am
>>> @@ -6,8 +6,8 @@ ODP_MODULES = pktio \
>>>               shmem
>>>     if test_vald
>>> -TESTS = pktio/pktio_run \
>>> -       pktio/pktio_run_tap \
>>> +TESTS = pktio/pktio_run.sh \
>>> +       pktio/pktio_run_tap.sh \
>>>         ring/ringtest$(EXEEXT) \
>>>         shmem/shmem_linux \
>>>         ${top_builddir}/test/validation/atomic/atomic_main$(EXEEXT) \
>>> @@ -38,20 +38,22 @@ TESTS = pktio/pktio_run \
>>>   SUBDIRS = $(ODP_MODULES)
>>>     if HAVE_PCAP
>>> -TESTS += pktio/pktio_run_pcap
>>> +TESTS += pktio/pktio_run_pcap.sh
>>>   endif
>>>   if PKTIO_IPC
>>> -TESTS += pktio_ipc/pktio_ipc_run
>>> +TESTS += pktio_ipc/pktio_ipc_run.sh
>>>   SUBDIRS += pktio_ipc
>>>   endif
>>>   if netmap_support
>>> -TESTS += pktio/pktio_run_netmap
>>> +TESTS += pktio/pktio_run_netmap.sh
>>>   endif
>>>   if PKTIO_DPDK
>>> -TESTS += pktio/pktio_run_dpdk
>>> +TESTS += pktio/pktio_run_dpdk.sh
>>>   endif
>>>   endif
>>>   +TEST_EXTENSIONS = .sh
>>> +
>>>   dist_check_SCRIPTS = run-test tests-validation.env $(LOG_COMPILER)
>>>     test_SCRIPTS = $(dist_check_SCRIPTS)
>>> diff --git a/platform/linux-generic/test/pktio/Makefile.am
>>> b/platform/linux-generic/test/pktio/Makefile.am
>>> index 3dcc1ee..4a14343 100644
>>> --- a/platform/linux-generic/test/pktio/Makefile.am
>>> +++ b/platform/linux-generic/test/pktio/Makefile.am
>>> @@ -1,15 +1,15 @@
>>>   dist_check_SCRIPTS = pktio_env \
>>> -                    pktio_run \
>>> -                    pktio_run_tap
>>> +                    pktio_run.sh \
>>> +                    pktio_run_tap.sh
>>>     if HAVE_PCAP
>>> -dist_check_SCRIPTS += pktio_run_pcap
>>> +dist_check_SCRIPTS += pktio_run_pcap.sh
>>>   endif
>>>   if netmap_support
>>> -dist_check_SCRIPTS += pktio_run_netmap
>>> +dist_check_SCRIPTS += pktio_run_netmap.sh
>>>   endif
>>>   if PKTIO_DPDK
>>> -dist_check_SCRIPTS += pktio_run_dpdk
>>> +dist_check_SCRIPTS += pktio_run_dpdk.sh
>>>   endif
>>>     test_SCRIPTS = $(dist_check_SCRIPTS)
>>> diff --git a/platform/linux-generic/test/pktio/pktio_run
>>> b/platform/linux-generic/test/pktio/pktio_run.sh
>>> similarity index 100%
>>> rename from platform/linux-generic/test/pktio/pktio_run
>>> rename to platform/linux-generic/test/pktio/pktio_run.sh
>>> diff --git a/platform/linux-generic/test/pktio/pktio_run_dpdk
>>> b/platform/linux-generic/test/pktio/pktio_run_dpdk.sh
>>> similarity index 100%
>>> rename from platform/linux-generic/test/pktio/pktio_run_dpdk
>>> rename to platform/linux-generic/test/pktio/pktio_run_dpdk.sh
>>> diff --git a/platform/linux-generic/test/pktio/pktio_run_netmap
>>> b/platform/linux-generic/test/pktio/pktio_run_netmap.sh
>>> similarity index 100%
>>> rename from platform/linux-generic/test/pktio/pktio_run_netmap
>>> rename to platform/linux-generic/test/pktio/pktio_run_netmap.sh
>>> diff --git a/platform/linux-generic/test/pktio/pktio_run_pcap
>>> b/platform/linux-generic/test/pktio/pktio_run_pcap.sh
>>> similarity index 100%
>>> rename from platform/linux-generic/test/pktio/pktio_run_pcap
>>> rename to platform/linux-generic/test/pktio/pktio_run_pcap.sh
>>> diff --git a/platform/linux-generic/test/pktio/pktio_run_tap
>>> b/platform/linux-generic/test/pktio/pktio_run_tap.sh
>>> similarity index 100%
>>> rename from platform/linux-generic/test/pktio/pktio_run_tap
>>> rename to platform/linux-generic/test/pktio/pktio_run_tap.sh
>>> diff --git a/platform/linux-generic/test/pktio_ipc/Makefile.am
>>> b/platform/linux-generic/test/pktio_ipc/Makefile.am
>>> index bc224ae..8858bd2 100644
>>> --- a/platform/linux-generic/test/pktio_ipc/Makefile.am
>>> +++ b/platform/linux-generic/test/pktio_ipc/Makefile.am
>>> @@ -16,5 +16,5 @@ dist_pktio_ipc2_SOURCES = pktio_ipc2.c ipc_common.c
>>>     EXTRA_DIST = ipc_common.h
>>>   -dist_check_SCRIPTS = pktio_ipc_run
>>> +dist_check_SCRIPTS = pktio_ipc_run.sh
>>>   test_SCRIPTS = $(dist_check_SCRIPTS)
>>> diff --git a/platform/linux-generic/test/pktio_ipc/pktio_ipc_run
>>> b/platform/linux-generic/test/pktio_ipc/pktio_ipc_run.sh
>>> similarity index 100%
>>> rename from platform/linux-generic/test/pktio_ipc/pktio_ipc_run
>>> rename to platform/linux-generic/test/pktio_ipc/pktio_ipc_run.sh
>>> diff --git a/test/performance/Makefile.am b/test/performance/Makefile.am
>>> index d61dee9..d23bb3e 100644
>>> --- a/test/performance/Makefile.am
>>> +++ b/test/performance/Makefile.am
>>> @@ -7,8 +7,10 @@ EXECUTABLES = odp_crypto$(EXEEXT)
>>> odp_pktio_perf$(EXEEXT)
>>>   COMPILE_ONLY = odp_l2fwd$(EXEEXT) \
>>>                odp_scheduling$(EXEEXT)
>>>   -TESTSCRIPTS = odp_l2fwd_run \
>>> -             odp_scheduling_run
>>> +TESTSCRIPTS = odp_l2fwd_run.sh \
>>> +             odp_scheduling_run.sh
>>> +
>>> +TEST_EXTENSIONS = .sh
>>>     if test_perf
>>>   TESTS = $(EXECUTABLES) $(TESTSCRIPTS)
>>> diff --git a/test/performance/odp_l2fwd_run
>>> b/test/performance/odp_l2fwd_run.sh
>>> similarity index 100%
>>> rename from test/performance/odp_l2fwd_run
>>> rename to test/performance/odp_l2fwd_run.sh
>>> diff --git a/test/performance/odp_scheduling_run
>>> b/test/performance/odp_scheduling_run.sh
>>> similarity index 100%
>>> rename from test/performance/odp_scheduling_run
>>> rename to test/performance/odp_scheduling_run.sh
>>>
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> https://lists.linaro.org/mailman/listinfo/lng-odp
>>
>
>
>
> --
> Mike Holmes
> Technical Manager - Linaro Networking Group
> Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
> "Work should be fun and collaborative, the rest follows"
>
>
>


-- 
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
"Work should be fun and collaborative, the rest follows"
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to