Regards, Bala
On 23 June 2016 at 16:13, Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com> wrote: > > >> -----Original Message----- >> From: Balasubramanian Manoharan [mailto:bala.manoha...@linaro.org] >> Sent: Monday, June 20, 2016 2:02 PM >> To: lng-odp@lists.linaro.org >> Cc: spin...@mellanox.com; Savolainen, Petri (Nokia - FI/Espoo) >> <petri.savolai...@nokia-bell-labs.com>; Balasubramanian Manoharan >> <bala.manoha...@linaro.org> >> Subject: [PATCH/API-NEXT 1/3] api: traffic_mngr: Add pktio interface to >> odp_tm_egress_t struct >> >> Replaces pktio interface as input to TM system instead of >> odp_pktout_queue_t.This creates an 1 to 1 mapping between a TM system >> and pktio interface. >> >> Signed-off-by: Balasubramanian Manoharan <bala.manoha...@linaro.org> >> --- >> include/odp/api/spec/traffic_mngr.h | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/include/odp/api/spec/traffic_mngr.h >> b/include/odp/api/spec/traffic_mngr.h >> index 83b89e7..8c4be4b 100644 >> --- a/include/odp/api/spec/traffic_mngr.h >> +++ b/include/odp/api/spec/traffic_mngr.h >> @@ -280,6 +280,12 @@ typedef struct { >> * expected to do. */ >> odp_bool_t tm_queue_shaper_supported; >> >> + /** egress_fcn_supported indicates whether the tm system supports >> + * egress function. It is an optional features used to receive the > > Typo: features -> feature > > >> + * packet from the tm system and its performance might be limited. >> + */ >> + odp_bool_t egress_fcn_supported; > > This new _supported flag would fit better e.g. just after "max_levels". This > patch locates it between "tm_queue_shaper_supported" and > "tm_queue_wred_supported", which is not logical (between > tm_queue_xxx_supported flags). Agreed. > > > Also all three patches should be squashed into one, since it's not a > backwards compatible change and build fails if e.g. only this first patch is > applied. Yes this can be done. I kept the header file changes as separate patch for ease of review. I will merge them as single patch in next version. Regards, Bala > > > -Petri _______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
