On Thu, Aug 4, 2016 at 11:03 AM, Maxim Uvarov <maxim.uva...@linaro.org> wrote:
> On 08/04/16 18:26, Brian Brooks wrote: > >> Reviewed-by: Brian Brooks <brian.bro...@linaro.org> >> >> On 08/04 09:18:14, Mike Holmes wrote: >> >>> +ret=0 >>> + >>> +run() >>> +{ >>> + echo odp_scheduling_run_proc starts with $1 worker threads >>> + echo ===================================================== >>> + >>> + $PERFORMANCE/odp_scheduling${EXEEXT} --odph_proc -c $1 || ret=1 >>> +} >>> + >>> +run 1 >>> +run 8 >>> + >>> +exit $ret >>> >> Seeing this randomly in both multithread and multiprocess modes: >> >> ../../../odp/platform/linux-generic/odp_queue.c:328:odp_queue_destroy():queue >> "sched_00_07" not empty >> ../../../odp/platform/linux-generic/odp_schedule.c:271:schedule_term_global():Queue >> not empty >> ../../../odp/platform/linux-generic/odp_schedule.c:294:schedule_term_global():Pool >> destroy fail. >> ../../../odp/platform/linux-generic/odp_init.c:188:_odp_term_global():ODP >> schedule term failed. >> ../../../odp/platform/linux-generic/odp_queue.c:170:odp_queue_term_global():Not >> destroyed queue: sched_00_07 >> ../../../odp/platform/linux-generic/odp_init.c:195:_odp_term_global():ODP >> queue term failed. >> ../../../odp/platform/linux-generic/odp_pool.c:149:odp_pool_term_global():Not >> destroyed pool: odp_sched_pool >> ../../../odp/platform/linux-generic/odp_pool.c:149:odp_pool_term_global():Not >> destroyed pool: msg_pool >> ../../../odp/platform/linux-generic/odp_init.c:202:_odp_term_global():ODP >> buffer pool term failed. >> ~/odp_incoming/odp_build/test/common_plat/performance$ echo $? >> 0 >> > > btw, if ipc pktio enable and termination function return error, than there > will be pool file in /dev/shm/. > In docker shm space limited to 64MB. So other test can began randomly fail > on pool allocation or pool usage. I've not enabled ipc pktio and this test doesn't do any pktio operations so I don't think that's the issue here. > > > Maxim. > > >> Potentially two items: one for correctly returning the failure code, and >> another related to teardown. Both beyond the scope of this patch which >> LGTM. >> > >