On 11 August 2016 at 13:01, Maxim Uvarov <maxim.uva...@linaro.org> wrote:
> I'm going to apply this patch to master. But test might fail on bug in
> term code. But I think we will have more eyes seeing this issue...
> If any objections please say asap.
I object
We have stated previously that no commit may ever break master becasue it
can hamper git bisect, in addition I dont see any Reviews, so no one has
had chance to take a proper look and sign off yet, it looks sensible to me
but I have not reviewed it.
No mature project should ever commit something that is not known benign
just see what happens, downstream users should expect much more rigour from
us. Can we point at a use case that is now fixed by this patch ? I think it
needs reviews at a minimum.
>
> Maxim.
>
>
> On 08/10/16 17:23, Bill Fischofer wrote:
>
>> Accumulate return codes from resource cleanup so callers can be aware of
>> termination failures.
>>
>> Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org>
>> ---
>> test/common_plat/performance/odp_scheduling.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/test/common_plat/performance/odp_scheduling.c
>> b/test/common_plat/performance/odp_scheduling.c
>> index 1d1bf01..1de79f7 100644
>> --- a/test/common_plat/performance/odp_scheduling.c
>> +++ b/test/common_plat/performance/odp_scheduling.c
>> @@ -965,15 +965,15 @@ int main(int argc, char *argv[])
>> for (j = 0; j < QUEUES_PER_PRIO; j++) {
>> queue = globals->queue[i][j];
>> - odp_queue_destroy(queue);
>> + ret += odp_queue_destroy(queue);
>> }
>> }
>> - odp_shm_free(shm);
>> - odp_queue_destroy(plain_queue);
>> - odp_pool_destroy(pool);
>> - odp_term_local();
>> - odp_term_global(instance);
>> + ret += odp_shm_free(shm);
>> + ret += odp_queue_destroy(plain_queue);
>> + ret += odp_pool_destroy(pool);
>> + ret += odp_term_local();
>> + ret += odp_term_global(instance);
>> return ret;
>> }
>>
>
>
--
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
"Work should be fun and collaborative, the rest follows"
