Re: [lng-odp] [PATCH 1/6] linux-gen: queue: reuse enq_ and deq_multi

[Maxim Uvarov]

On 09/21/16 15:06, Savolainen, Petri (Nokia - FI/Espoo) wrote:
-----Original Message-----
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim
Uvarov
Sent: Wednesday, September 21, 2016 2:35 PM
To: lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCH 1/6] linux-gen: queue: reuse enq_ and
deq_multi
odp check fails for this patch:

[01] num pktios 1, PKTIN_DIRECT, PKTOUT_DIRECT
../../helper/linux.c:273:odpthread_run_start_routine():helper: ODP
worker thread started as linux pthread. (pid=10762)
[02] num pktios 1, PKTIN_DIRECT, PKTOUT_DIRECT
17 pps, 17 max pps,  0 rx drops, 0 tx drops
9 pps, 17 max pps,  0 rx drops, 0 tx drops
10 pps, 17 max pps,  0 rx drops, 0 tx drops
10 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
7 pps, 17 max pps,  0 rx drops, 0 tx drops
9 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
7 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
7 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
7 pps, 17 max pps,  0 rx drops, 0 tx drops
7 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
5 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
5 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
6 pps, 17 max pps,  0 rx drops, 0 tx drops
TEST RESULT: 17 maximum packets per second.
Exit 0

FAIL: pps below threshold 17 < 5000
pktio: removing test interfaces pktiop0p1, pktiop1p0, pktiop2p3, pktiop3p2
pktio: removing test interfaces pktiop0p1, pktiop1p0, pktiop2p3, pktiop3p2

Which config ?

  $ ./configure --with-platform=linux-generic 
--prefix=/opt/Linaro/check-odp-v3.git/new-build --enable-test-perf 
--enable-test-perf-proc --enable-test-helper --enable-test-example 
--enable-test-vald --with-testdir=yes

Which pktio ?

socket mmap

pktio: setting up test interfaces pktiop0p1, pktiop1p0, pktiop2p3, 
pktiop3p2.
 PKTIO: initialized loop interface.
 PKTIO: initialized pcap interface.
 PKTIO: initialized socket mmap, use export 
ODP_PKTIO_DISABLE_SOCKET_MMAP=1 to disable.
 PKTIO: initialized socket mmsg,use export 
ODP_PKTIO_DISABLE_SOCKET_MMSG=1 to disable.

  Which test case ?
test/common_plat/performance/odp_l2fwd_run

For validation I run apply-and-build.sh script with following parameters:
GIT_BRANCH=master PATCH_DIR=/opt/Linaro/odp3.git IGNORE_BASE=0 CLEANUP=0 
ENABLE_DPDK_PKTIO=0 ENABLE_IPC_PKTIO=0 DISTCHECK=1 ./apply-and-build.sh

Maxim.

-Petri