On 10/20/16 15:00, Savolainen, Petri (Nokia - FI/Espoo) wrote:

-----Original Message-----
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim
Uvarov
Sent: Wednesday, October 19, 2016 3:59 PM
To: lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCH 01/10] linux-gen: ipc: disable build of ipc
pktio

On 10/19/16 15:09, Petri Savolainen wrote:
IPC pktio implementation depends heavily on pool internals. It's
build is disabled due to pool re-implementation. IPC should be
re-implemented with a cleaner internal interface towards pool and
shm.

Signed-off-by: Petri Savolainen <petri.savolai...@nokia.com>
---
   platform/linux-generic/Makefile.am | 2 --
   1 file changed, 2 deletions(-)

diff --git a/platform/linux-generic/Makefile.am b/platform/linux-
generic/Makefile.am
index 0ec13d4..0fba393 100644
--- a/platform/linux-generic/Makefile.am
+++ b/platform/linux-generic/Makefile.am
@@ -111,7 +111,6 @@ noinst_HEADERS = \
                  ${srcdir}/include/odp_name_table_internal.h \
                  ${srcdir}/include/odp_packet_internal.h \
                  ${srcdir}/include/odp_packet_io_internal.h \
-                 ${srcdir}/include/odp_packet_io_ipc_internal.h \
                  ${srcdir}/include/odp_packet_io_queue.h \
                  ${srcdir}/include/odp_packet_io_ring_internal.h \
                  ${srcdir}/include/odp_packet_netmap.h \
@@ -158,7 +157,6 @@ __LIB__libodp_linux_la_SOURCES = \
                           odp_packet_io.c \
                           pktio/ethtool.c \
                           pktio/io_ops.c \
-                          pktio/ipc.c \
                           pktio/pktio_common.c \
                           pktio/loop.c \
                           pktio/netmap.c \
you just not need to turn on  -D_ODP_PKTIO_IPC from configure. If it's
not enough add ifdefs inside pktio/ipc.c.
Or with your changes tests will be built and run.

Maxim.

Entire IPC code won't build after pool structure changes. So, entire ipc.c file 
would need to be #ifdef'ed. I think this was a cleaner way to disable entirely 
the build of IPC code.

-Petri
yes. You can ifdef it. Then we merge Christophe changes and ipc repair. Than your changes and I will try to fix it again.

Maxim.


Reply via email to