Petri,
please review API patch.
On 10/31/16 11:52, Christophe Milard wrote:
The ODP_SHM_SINGLE_VA flag is created: when set (at odp_shm_reserve()),
this flag guarantees that all ODP threads sharing this memory
block will see the block at the same address (regadless of ODP
thread type -pthread vs process- or fork time)
The flag ODP_SHM_EXPORT is added: when passed at odp_shm_reserve() time
the memory block becomes visible to other ODP instances.
The function odp_shm_find_exported() is added: this function enables to
reserve block of memories exported by other ODP instances (using the
ODP_SHM_EXPORT flag).
Signed-off-by: Christophe Milard <christophe.mil...@linaro.org>
---
include/odp/api/spec/shared_memory.h | 38 +++++++++++++++++++++++++++++++-----
1 file changed, 33 insertions(+), 5 deletions(-)
diff --git a/include/odp/api/spec/shared_memory.h
b/include/odp/api/spec/shared_memory.h
index 8c76807..80cc143 100644
--- a/include/odp/api/spec/shared_memory.h
+++ b/include/odp/api/spec/shared_memory.h
@@ -14,6 +14,7 @@
#ifndef ODP_API_SHARED_MEMORY_H_
#define ODP_API_SHARED_MEMORY_H_
#include <odp/visibility_begin.h>
+#include <odp/api/init.h>
#ifdef __cplusplus
extern "C" {
@@ -43,12 +44,25 @@ extern "C" {
#define ODP_SHM_NAME_LEN 32
/*
- * Shared memory flags
+ * Shared memory flags:
*/
-
-/* Share level */
-#define ODP_SHM_SW_ONLY 0x1 /**< Application SW only, no HW access */
-#define ODP_SHM_PROC 0x2 /**< Share with external processes */
+#define ODP_SHM_SW_ONLY 0x1 /**< Application SW only, no HW
access */
+#define ODP_SHM_PROC 0x2 /**< Share with external processes */
+/**
+ * Single virtual address
+ *
+ * When set, this flag guarantees that all ODP threads sharing this
+ * memory block will see the block at the same address - regardless
+ * of ODP thread type (e.g. pthread vs. process (or fork process time)).
+ */
+#define ODP_SHM_SINGLE_VA 0x4
+/**
+ * Export memory
+ *
+ * When set, the memory block becomes visible to other ODP instances
+ * through odp_shm_find_exported().
+ */
+#define ODP_SHM_EXPORT 0x08
/**
* Shared memory block info
@@ -135,6 +149,20 @@ int odp_shm_free(odp_shm_t shm);
*/
odp_shm_t odp_shm_lookup(const char *name);
+/**
+ * Get and reserve a block of shared memory, exported by another ODP instance
+ *
+ * @param remote_name Name of the block, in the remote ODP instance
+ * @param odp_inst Remote ODP instance, as returned by odp_init_global()
+ * @param local_name Name given to the block, in the local ODP instance
+ * (or NULL, if the application doesn't care)
+ *
+ * @return A new handle to the block if it is found (must be freed when done).
+ * @retval ODP_SHM_INVALID on failure
+ */
+odp_shm_t odp_shm_find_exported(const char *remote_name,
+ odp_instance_t odp_inst,
+ const char *local_name);
I might lost some discussion. But for now it looks like we can
extend odp_shm_lookup() with that arguments. I.e. if odp_inst = 0,
local look up will be done.
Maxim.
/**
* Shared memory block address