On 6 December 2016 at 12:05, Nicolas Morey-Chaisemartin <nmo...@kalray.eu> wrote: > This is the suffix to be used to compute the name of ODP > and ODP helper libraries. > platform can set a ODP_LIB_SUFFIX which is then exported as > ODP_LIB_FLAVOR and ODP_LIB_FLAVOR_AM (for automake rules)
I think this should be ODP_LIB_IMPL -> (IMPLEMENTATION) I initially thought platform but I believe that it it will be likely that one platform may be built in more than one way so there is not a 1:1 correlation to odp/platform. An example might be Petris suggestions for building a static .so (API incompatible) in addition to the normal .so and .a files, this will need a different suffix. libodp.so -> regular ABI compatible library libodp-static.so -> modified non ABI compatible .so that it has a lib version of 0.0.0. This is not something that we should build but it is possible for a developer to set ODP_LIB_IMPL=static along with the ABI flags they want. And the others we know of are libodp-mpaa libodp-dpdk > > Signed-off-by: Nicolas Morey-Chaisemartin <nmo...@kalray.eu> > --- > configure.ac | 1 + > platform/linux-generic/m4/configure.m4 | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/configure.ac b/configure.ac > index 3e89b0a..01d6448 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -310,6 +310,7 @@ AC_SUBST([CFLAGS]) > AC_SUBST([AM_LDFLAGS]) > AC_SUBST([LDFLAGS]) > AC_SUBST([EXEEXT]) > +AC_SUBST([ODP_LIB_FLAVOR]) > > AC_OUTPUT > AC_MSG_RESULT([ > diff --git a/platform/linux-generic/m4/configure.m4 > b/platform/linux-generic/m4/configure.m4 > index d3e5528..d5a7e1f 100644 > --- a/platform/linux-generic/m4/configure.m4 > +++ b/platform/linux-generic/m4/configure.m4 > @@ -38,3 +38,5 @@ m4_include([platform/linux-generic/m4/odp_schedule.m4]) > > AC_CONFIG_FILES([platform/linux-generic/Makefile > > platform/linux-generic/include/odp/api/plat/static_inline.h]) > + > +ODP_LIB_FLAVOR=-linux > -- > 2.10.1.4.g0ffc436 > > -- Mike Holmes Program Manager - Linaro Networking Group Linaro.org │ Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
