> -----Original Message----- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Monday, January 09, 2017 11:00 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: lng-odp-forward <lng-odp@lists.linaro.org> > Subject: Re: [lng-odp] [API-NEXT PATCH 0/5] Packet header optimizations > > This series looks good, however it conflicts with the packet reference > patch series since that series is adding fields to the packet header. > Since the purpose here is to optimize the packet header layout based > on your measurements, I suggest it follow the merge of the packet > reference series so that the revised header can be optimized. >
Since adding support for references is not a trivial modification, I suggest that this set would be merged first. It gives performance (and code simplicity) baseline for packet references. Addition of reference support should not change the normal, single packet performance (more than few cycles from couple of if(unlikely(has_ref)) conditions). Also the API spec text needs to be tightened still. I'll send a proposal for API and possibly also for simpler implementation. -Petri
