> -----Original Message----- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Thursday, January 19, 2017 11:53 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- > labs.com> > Cc: lng-odp-forward <lng-odp@lists.linaro.org> > Subject: Re: [lng-odp] [PATCH 0/8] First ABI files > > This series represents a significant structural change and as such > should go against api-next, not master. Patches aimed at master should > be bug fixes, not something that introduces new structure development.
I think we should stop right here of doing "significant changes" through api-next. Last time that policy effectively stopped the work in master due to dependencies over many files changed. Api-next should be reserved only for API spec changing modifications, since only those are visible to applications. E.g. changes in ABI does not require any application change. Today our "ABI" support is non-existent. This sets ground work for files and Makefiles to enable ABI(s) and force that. > > While the goals here seem good, I'm concerned that at this stage > applying this removes strong typing support. For example, as an > experiment I changed the buffer validation test to contain this error: I'll look into strong typing as default. But vendors may very well agree not to support it, since it requires handles to be pointer size types. E.g. arm64 ABI may be agreed to use uint32_t for handles instead of pointers. -Petri
