Hi, Bill and Mike Thanks for your comments, Kevin starts his vacation till Feb 3, Song and I will bring this thread up to him.
Best Regards, Yi On 21 January 2017 at 22:53, Bill Fischofer <bill.fischo...@linaro.org> wrote: > In general these look good, but still have some problems: > > 1. The are checkpatch formatting issues in parts 1, 2, and 3. Please > run ./scripts/checkpatch on your patches before submitting and ensure > that they are clean. > > 2. Each new revision of a patch should increment the version number. > This one really should have been PATCHv2 since it was a resubmittal of > the original. So for the next revision please be sure you use the > command: > > git format-patch origin/api-next --subject-prefix="API-NEXT PATCHv3" > > I suspect this should also fix Mike's noted issue with the series > since you didn't increment the version number last time but changed > the patch structure. > > On Fri, Jan 20, 2017 at 10:43 AM, Mike Holmes <mike.hol...@linaro.org> > wrote: > > Hi Kevin > > > > How did you send these patches ? > > If you look in patchworks it can't identify them as a series and gives > > them odd names. http://patches.opendataplane.org/project/lng-odp/list/ > > > > Untitled series #10 > > Untitled series #11 > > Untitled series #12 > > > > Even though they claim to be (n) of 4 > > > > Perhaps you did not generate them with git format patch as a series > > but manually changed their names ? > > > > Mike > > > > On 20 January 2017 at 00:21, Kevin Wang <kevin.w...@linaro.org> wrote: > >> Currently, user needs to decide the timer resolution before creating > >> a timer pool. But sometimes it will cause timer overrun as the system > >> can't support such high resolution. > >> So a new API is required to expose the timer capability to the user. > >> > >> Signed-off-by: Kevin Wang <kevin.w...@linaro.org> > >> --- > >> include/odp/api/spec/timer.h | 21 +++++++++++++++++++++ > >> 1 file changed, 21 insertions(+) > >> > >> diff --git a/include/odp/api/spec/timer.h b/include/odp/api/spec/timer.h > >> index 75f9db9..78d9119 100644 > >> --- a/include/odp/api/spec/timer.h > >> +++ b/include/odp/api/spec/timer.h > >> @@ -108,6 +108,27 @@ typedef struct { > >> } odp_timer_pool_param_t; > >> > >> /** > >> + * Timer capability > >> + */ > >> +typedef struct { > >> + uint64_t res_ns; /**< Timeout resolution in nanoseconds */ > >> +} odp_timer_capability_t; > >> + > >> + > >> +/** > >> + * Query Timer interface capabilities > >> + * > >> + * Outputs Timer interface capabilities on success. > >> + * > >> + * @param clk_src Clock source for timers > >> + * @param[out] capa Pointer to capability structure for output > >> + * > >> + * @retval 0 on success > >> + * @retval <0 on failure > >> + */ > >> +int odp_timer_capability(odp_timer_clk_src_t clk_src, > odp_timer_capability_t *capa); > >> + > >> +/** > >> * Create a timer pool > >> * > >> * The use of pool name is optional. Unique names are not required. > >> -- > >> 1.9.1 > >> > > > > > > > > -- > > Mike Holmes > > Program Manager - Linaro Networking Group > > Linaro.org │ Open source software for ARM SoCs > > "Work should be fun and collaborative, the rest follows" >
