Merged,
Maxim.
On 01/25/17 18:59, Bill Fischofer wrote:
> I also think this cleanup is a step in the right direction. If the
> helpers are to be an adjunct ODP package that can be distributed
> alongside ODP then this is what's needed. Otherwise they are just a
> disjoint set of unrelated individual files that we should not try to
> package at all. But that would mean their use would be restricted to
> embedded ODP users, and the expectation is that most ODP users going
> forward are going to be working from a distribution in more of a cloud
> environment rather than the ODP repo.
>
> So +1 from me on this. These things can always be improved, but that
> can be done in stages building on this work.
>
> On Wed, Jan 25, 2017 at 8:30 AM, Christophe Milard
> <christophe.mil...@linaro.org> wrote:
>> For the series:
>>
>> Reviewed-by: Christophe Milard <christophe.mil...@linaro.org>
>>
>> On 23 January 2017 at 20:46, Mike Holmes <mike.hol...@linaro.org> wrote:
>>> Greatly reduce the proliferation of helper includes that every app needs
>>> Make the public helper API very obvious
>>> Fix recent inclusion of table APIs that were not in the helper include dir
>>> and
>>> were not exported during install.
>>>
>>> Mike Holmes (4):
>>> helper: add odph_api.h for existing exported headers
>>> helper: use odph_api.h for test include for unexported files
>>> test: use odph_api.h
>>> examples: use odph_api.h
>>>
>>> example/classifier/odp_classifier.c | 4 +--
>>> example/generator/odp_generator.c | 6 +---
>>> example/ipsec/odp_ipsec.c | 6 +---
>>> example/ipsec/odp_ipsec_fwd_db.h | 1 -
>>> example/ipsec/odp_ipsec_loop_db.h | 1 -
>>> example/ipsec/odp_ipsec_misc.h | 4 +--
>>> example/ipsec/odp_ipsec_stream.c | 4 +--
>>> example/l2fwd_simple/odp_l2fwd_simple.c | 4 +--
>>> example/l3fwd/odp_l3fwd.c | 6 +---
>>> example/l3fwd/odp_l3fwd_db.h | 2 +-
>>> example/packet/odp_pktio.c | 4 +--
>>> example/switch/odp_switch.c | 4 +--
>>> example/time/time_global_test.c | 2 +-
>>> example/timer/odp_timer_test.c | 2 +-
>>> helper/Makefile.am | 11 +++---
>>> helper/cuckootable.c | 2 +-
>>> helper/hashtable.c | 2 +-
>>> helper/include/odp/helper/odph_api.h | 39
>>> ++++++++++++++++++++++
>>> helper/{ => include/odp/helper}/odph_cuckootable.h | 0
>>> helper/{ => include/odp/helper}/odph_hashtable.h | 0
>>> .../{ => include/odp/helper}/odph_iplookuptable.h | 0
>>> helper/{ => include/odp/helper}/odph_lineartable.h | 0
>>> helper/iplookuptable.c | 2 +-
>>> helper/lineartable.c | 2 +-
>>> helper/test/chksum.c | 4 +--
>>> helper/test/cuckootable.c | 2 +-
>>> helper/test/iplookuptable.c | 2 +-
>>> helper/test/odpthreads.c | 2 +-
>>> helper/test/parse.c | 3 +-
>>> helper/test/table.c | 3 +-
>>> test/common_plat/common/odp_cunit_common.c | 2 +-
>>> test/common_plat/performance/odp_crypto.c | 2 +-
>>> test/common_plat/performance/odp_l2fwd.c | 4 +--
>>> test/common_plat/performance/odp_pktio_perf.c | 5 +--
>>> test/common_plat/performance/odp_sched_latency.c | 2 +-
>>> test/common_plat/performance/odp_scheduling.c | 2 +-
>>> .../api/classification/odp_classification_common.c | 4 ---
>>> .../classification/odp_classification_test_pmr.c | 4 ---
>>> .../api/classification/odp_classification_tests.c | 4 ---
>>> .../classification/odp_classification_testsuites.h | 1 +
>>> test/common_plat/validation/api/pktio/pktio.c | 4 +--
>>> test/common_plat/validation/api/timer/timer.c | 2 +-
>>> .../validation/api/traffic_mngr/traffic_mngr.c | 6 +---
>>> test/linux-generic/mmap_vlan_ins/mmap_vlan_ins.c | 4 +--
>>> test/linux-generic/pktio_ipc/ipc_common.h | 5 +--
>>> test/linux-generic/ring/ring_stress.c | 2 +-
>>> 46 files changed, 80 insertions(+), 97 deletions(-)
>>> create mode 100644 helper/include/odp/helper/odph_api.h
>>> rename helper/{ => include/odp/helper}/odph_cuckootable.h (100%)
>>> rename helper/{ => include/odp/helper}/odph_hashtable.h (100%)
>>> rename helper/{ => include/odp/helper}/odph_iplookuptable.h (100%)
>>> rename helper/{ => include/odp/helper}/odph_lineartable.h (100%)
>>>
>>> --
>>> 2.9.3
