> -----Original Message----- > From: Christophe Milard [mailto:christophe.mil...@linaro.org] > Sent: Friday, February 03, 2017 2:29 PM > To: Petri Savolainen <petri.savolai...@linaro.org> > Cc: LNG ODP Mailman List <lng-odp@lists.linaro.org> > Subject: Re: [lng-odp] [PATCH 1/2] helper: linux: renamed threads_extn to > linux helpers > > On 3 February 2017 at 12:23, Petri Savolainen > <petri.savolai...@linaro.org> wrote: > > There's no platform specific helpers. Helpers may depend on > > Linux and make it easier to do common series of Linux system > > calls. These kind of helpers are grouped into helper/linux > > directory. > > This is getting really confusing to me! Haven't we defined a > "platform" as being a couple {OS, HW}? That is any change in this > couple makes a new platform... > If we hold to this definition, then linux-helpers becomes platform > helpers... > Now, my humble opinion is that no-one is using these linux-only > helpers and no one ever will unless to enforce their usage by example > that people could copy/paste: why would a programmer want to replace a > well known linux system call by an ODP helper call? to save a for > loop?. > We are hitting the same usual problem of lack of proper definition for > things, but in this special case, my proposal is called "deletion". > :-) > > Christophe
This is needed by OFP, for example. The current ODP master (after v1.13) moved things backwards as linux helper (which create e.g. pthreads and call odp_local_init / _term() for those) was renamed as "linux-generic helper". That would need OFP to expose "helper/linux-generic/..." in its Makefiles, which is both ugly and wrong (in the sense that helper code is part application code, not implementation code). -Petri
