> -----Original Message----- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Tuesday, February 07, 2017 2:10 AM > To: Petri Savolainen <petri.savolai...@linaro.org> > Cc: lng-odp-forward <lng-odp@lists.linaro.org> > Subject: Re: [lng-odp] [PATCH 04/10] test: l2fwd: add pktio driver print > out > > It's not clear why this unrelated patch is part of this series. The > only parts that seem relevant to this series are Parts 1, 2, 3, 9, and > 10. The rest should either be their own patches or else be part of a > general "miscellaneous cleanups" series.
All those "extra" patches are fixing issues in test apps, etc and make debugging (packet implementation changes) easier. E.g. this print out of driver name is useful when you want to be sure that you are testing with particular pktio (e.g. netmap vs socket). Current implementation of pktio moves from one failing pktio_open() to next one until an open succeeds or we are out of pktio drivers. Now e.g. if pktio_open() fails for netmap during development (for some reason), a following pktio_open() for socket may continue from there and you end up running socket code while you think you are running netmap code. -Petri
