Thanks a million Maxim! Patch submitted.
On Tue, 2017-02-28 at 18:57 +0300, Maxim Uvarov wrote: > git format-patch HEAD^ > perl ./scripts/checkpatch.pl *.patch > > git send-email --to lng-odp@lists.linaro.org *.patc > > > On 28 February 2017 at 18:54, Marco Varlese <marco.varl...@suse.com> wrote: > > Hi, > > I'm trying to submit the patch but without much success... > > > > mvarlese@linux-yk3w:~/repos> git clone https://git.linaro.org/lng/odp.git > > > > > > mvarlese@linux-yk3w:~/repos/odp> git config --global user.name "Marco Varlese" > > > > mvarlese@linux-yk3w:~/repos/odp> git config --global user.email > > > > "marco.varle s...@suse.com" > > > > mvarlese@linux-yk3w:~/repos/odp> git checkout -b fix_cpuset_size_assert > > > > mvarlese@linux-yk3w:~/repos/odp> git add platform/linux- generic/include/odp/api/plat/cpumask_types.h > > > > mvarlese@linux-yk3w:~/repos/odp> git commit -s > > > > > > [fix_cpuset_size_assert 2728409] As per mailing-list and meeting conversation: this patch addresses the build failure on operating systems where CPU_SETSIZE is bigger than 1024 entries. > > 1 file changed, 1 insertion(+), 1 deletion(-) > > mvarlese@linux-yk3w:~/repos/odp> > > > > > > mvarlese@linux-yk3w:~/repos/odp> git push --set-upstream origin fix_cpuset_size_assert > > > > > > fatal: unable to access 'https://git.linaro.org/lng/odp.git/': The > > > > > > requested URL returned error: 403 > > > > > > Are you positive I don't need any special step to be done (e.g. register account, SSH key uploaded, etc.)? > > > > > > Thanks, > > Marco > > > > > > On Tue, 2017-02-28 at 06:38 -0600, Bill Fischofer wrote: > > > > > > > > > > > > I've added this topic to the agenda for today's ODP > > > > > > > > > > > > public call. Marco, if you're able to join us to provide your input to the discussion please do so. The call is at 15:00 UTC. To join just go to http://meetings.opendatap lane.org. We use the BlueJeans conferencing system. Thanks. > > > > > > > > > On Tue, Feb 28, 2017 at 3:02 AM, Maxim Uvarov > > > > > > > > > <maxim.uva...@linaro.org> wrote: > > > > > > > > the problem is that if you compile binary on let's say ubuntu > > > > > > > > it might not > > > > work on suse with more then 1024 cpus. > > > > > > > > > > > > > > > > > > > > > > > > On 28 February 2017 at 11:52, Marco Varlese > > > > > > > > > > > > <marco.varl...@suse.com> wrote: > > > > > > > > > > > > > > > > > > > > > On Tue, 2017-02-28 at 08:12 +0000, Savolainen, Petri (Nokia - FI/Espoo) > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > [nip] > > > > > > > > > > > > > > > > > > > /** > > > > > > > > > > * @def ODP_CPUMASK_SIZE > > > > > > > > > > > > > > * Maximum cpumask size, this definition limits the number > > > > > > > > > >of individual > > > > > > > > > CPUs > > > > > > > > > > * that can be accessed in this system. > > > > > > > > > > */ > > > > > > > > > > > > > > > > > > > > > > > > It cannot be removed, it's part of API. Just need to find a > > > > > > > > > > way to set > > > > > > > > > it to > > > > > > > > > > > > > > CPU_SETSIZE (on Linux systems). ODP API spec is OS > > > > > > > > > > agnostic. The same > > > > > > > > > > > > > > application code should run also on non-Linux > > > > > > > > > > implementations (e.g. ODP > > > > > > > > > API > > > > > > > > > > spec cannot refer to CPU_SETSIZE). The assert is needed as long as > > > > > > > > > > ODP_CPUMASK_SIZE value is not set from CPU_SETSIZE. > > > > > > > > > > > > > > > > > > > > -Petri > > > > > > > > > > > > > > > > > > > I thought it could not be removed as well. > > > > > > > > > What about something like this... > > > > > > > > > > > > > > > > > > ==== > > > > > > > > > #ifdef __unix__ > > > > > > > > > > > > > > > > > > #define _GNU_SOURCE > > > > > > > > > #include <sched.h> > > > > > > > > > #define ODP_CPUMASK_SIZE CPU_SETSIZE > > > > > > > > > > > > > > > > > > #elif > > > > > > > > > > > > > > > > > > #define ODP_CPUMASK_SIZE 1024 > > > > > > > > > > > > > > > > > > #endif > > > > > > > > > > > > > > > > > > #define ODP_CPUMASK_STR_SIZE ((ODP_CPUMASK_SIZE + 3) / 4 + 3) > > > > > > > > > ==== > > > > > > > > > > > > > > > > > > > > > > However, something is going on with the ODP build system > > > > > > > > > since it cannot > > > > > > > > > find > > > > > > > > > CPU_SETSIZE (/usr/include/sched.h)... > > > > > > > > > > > > > > > > > > > > > > > > > > > Cheers, > > > > > > > > > Marco > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
