On Tue, Mar 14, 2017 at 1:52 AM, Elo, Matias (Nokia - FI/Espoo) < matias....@nokia-bell-labs.com> wrote:
> > > On 13 Mar 2017, at 19:58, Bill Fischofer <bill.fischo...@linaro.org> > wrote: > > > > This is a good start and I have no problem merging this as-is if we want > to do this in stages, but I think a bit more is needed. For one, this is > using a fixed offset for all references. I'd like to see references created > with a couple of different offsets (e.g., 0 and packet_len/2) to get a > better feel for any variability in performance due to different offsets, > especially as we expect most references to be created with relatively small > offsets covering packet headers rather than payload. > > > > Aside from that, for completeness we really should measure all of the > other ODP packet APIs when the input argument is a reference. That would > allow us to verify that there are no meaningful performance differences > between using references vs. non-references in these other APIs. > > > > I agree with this but it will take a while until I actually have time to > implement this. So I would suggest merging this simple patch first before > implementing a more comprehensive test suite for the packet references. > > Testing with zero offset would be a trivial change and could be added > already to this patch if required. > Sure. I've added my review to v2 and you can look to add the extra stuff as time permits. > > -Matias >
