> -----Original Message----- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Honnappa Nagarahalli > Sent: Wednesday, March 29, 2017 6:28 AM > To: Bill Fischofer <bill.fischo...@linaro.org>; Brian Brooks > <brian.bro...@arm.com> > Cc: Ola Liljedahl <ola.liljed...@arm.com>; Kevin Wang > <kevin.w...@arm.com>; lng-odp-forward <lng-odp@lists.linaro.org> > Subject: Re: [lng-odp] [API-NEXT 4/4] A scalable software scheduler > > I had run the checkpatch.pl, but I did not see these issues. May be it was > to do with the way I generated the patch. I will address the ones that > make sense. >
Checkpatch should pass cleanly for every patch. If you want an exception for some line, then you should give rationale for that e.g. on the cover letter. So, the expectation is that you will correct all and only few, well justified exceptions could be acceptable. An example would be a call to an external library (e.g. openssl) which uses camelCase function names - checkpatch warns but you cannot do anything about it. -Petri
